Deividas Talkevicius

Latest comments

• 

  Talkevicius•10

  @Talkevicius

  Submitted about 1 month ago

  What are you most proud of, and what would you do differently next time?

  Overview: This first challenge, wasn't hard, I'd like to think, I did the challenge well, although I'm a little bit confused about when to use h1,h2,etc-semantics.

  What challenges did you encounter, and how did you overcome them?

  Challenge: There weren't any real challenges.

  What specific areas of your project would you like help with?

  Question: This challenge, wasn't hard, the only problem I found was that it showed mobile and desktop designs to create, but they didn't actually differ, so the only confusing part was should I have used media-query for something.

  

  qr code component

  3

  40
  

  Deividas Talkevicius•40

  @Deivistalk

  Posted about 1 month ago

  Good job on completing your first challenge. May this be the first one of many :) Comparing design there are several differences:

  1. Margin for text - bigger spaces than mockup.
  2. Margin for picture - original has less space around it.
  3. Text color - your text is black, while original has grey for paragraph and header is kind of blueish (mac screen, maybe another one would show differently).
  4. Box shadow - this one is subtle, but original has one.

  What you got right that I see wrong quite often are widths, good job on that.

  Now for semantics it was pointed out correctly, that it's good to use known elements such as section. While it's convenient to have div's for every element, in the long run it's easier and more tidy to have as few of them as possible, so best case would have been to have a div/main flex/grid container and all child elements to be their intended element, such as img/h2/p. Mustafa gave a nice example, however in this case there's only one element in the whole document, so class names are not really needed, but it's a good example how to name them accordingly.

  As for headers, h1 goes for the main header. This looks like it could be used here, but in real life this would be a reusable component, so something between h2-h5 would be good, I would aim for the look instead of worrying which tag to put.

  Good job, good luck on next one!

  1

  Marked as helpful
• 

  Hanana•190

  @meantoes

  Submitted 3 months ago

  What are you most proud of, and what would you do differently next time?

  decided to start over and learn how to build things again, tryna code daily so frontendmentor.io would be the best to do it

  What challenges did you encounter, and how did you overcome them?

  kinda stuck to fit the image size like the design, so I just used width 100% on both the div and image.

  

  just a card solution

  1

  10
  

  Deividas Talkevicius•40

  @Deivistalk

  Posted 2 months ago

  Hello, great job at trying this challange! Few things to mention: pictures are not present, while I don't use react, maybe the solution is relative urls: ./assets/... Also main title should have a hovered state, could be like this: h1 :hover{color: ...} or title :hover{...} Other than that good job on using flexbox and picking correct colors!

  0
• 

  Erfun•110

  @ErfanTkh21

  Submitted 3 months ago

  

  QR code component

  1

  00
  

  Deividas Talkevicius•40

  @Deivistalk

  Posted 3 months ago

  Hello, good job on qr component challange! It looks great, however a minor thing to note. It seems like alignment did not work. Looking at the site, looks like body does not take 100% of the view height. To make it 100% height, you can add height to html and then body. Something like this would work: html, body{ height: 100%; } Other than that - margin between paragraph and heading should be a little smaller and paragraph should be a little more compact in width. Best of luck!

  0