Skip to content
OverviewSolutions
19
Comments
4
P
Diu Gach
@DevDiu071

All comments

  • Olabimpe•300
    @Lapupeh
    What specific areas of your project would you like help with?

    All feedbacks are welcome!

    Contact form

    1
    P
    Diu Gach•460
    @DevDiu071

    Hey @Lapupeh, well done on this project.

    Form validation, the animation are working fine, what you could adjust is the overflow, for some small devices eg small laptops there seems to be an overflow, I would suggest you add overflow hidden so that it disappears, all in all the project looks and works good.

  • P
    Diu Gach•460
    @DevDiu071

    Hey @khushi0433, good solution right there.

    I would suggest that you build your projects with accessibility in mind to help others with disabilities access your sites, you might be tempted to consider it later as I have been myself, but I realized the early you start implementing it in your projects the better.

    You could make the accordion headings accessible with keyboards so that users without mouse or with phyicial disabilities can be able to toggle the FAQ with their keyboards by clicking enter. since the element with faq-container class is a header you can as well just use header element instead of div to help screen readers read your content.

    You can implement the faq headings like this

    <h2> <button> Your heading here! </button> </h2> <div> accordion panel here! </div>

    you can visit this documentation to learn more about accessibility: https://developer.mozilla.org/en-US/docs/Learn_web_development/Core/Accessibility/What_is_accessibility and also from frontendmentor learning paths.

    overall the projects looks and works good.

  • P
    Diu Gach•460
    @DevDiu071

    Hey Marko, your project looks great, the functionalities works as expected, one thing I can suggest about the mobile version, you can add a little padding or margin on both sides of the design horizontally. amazing work.

    Also, instead of naming functions like buttonClick1 and 2, you can use descriptive names to help someone understand what the button does and what button is it.

  • P
    Diu Gach•460
    @DevDiu071

    Nice work Rajat, one thing you could adjust, there seems to be a big gap in the destination page between the destination image and the content. another thing I noticed, the images in the technology page are not changing when a visitor clicks on one of the three buttons. All in all you did a great job.