Skip to content
OverviewSolutions
12
Comments
10
Dorm-24
@Dorm-24

All comments

  • Dorm-24•200
    @Dorm-24

    Hi, your solution looks good! I don't know what happened with the font that should be used here. Your javascript code is a bit messy and the functionality has some bugs. For example the first thing I noticed it that when you type a bit in the inputs and then you delete them it has a bug where the message "cannot be zero" still stays. I'm not sure what advice to give you, try to do more js challenges and practise more!

    Marked as helpful
  • Dorm-24•200
    @Dorm-24

    Hi Robiul, Your solution looks great! I especially liked how you used JavaScript to generate the cards. I think it's a creative approach that works well.

    One small point I noticed is that the breakpoint for the mobile layout is currently set at 1200px, which feels a bit high. I think something closer to 700–800px might better match common mobile screen sizes.

    That aside, it’s a solid implementation!

  • Dorm-24•200
    @Dorm-24

    Hi Abdurohman Seid, your solution still needs a lot of improvement. The design and mobile layout need work, and the fact that there's no JavaScript in a project meant for a JavaScript learning path is a major issue. I suggest looking at other people's solutions, including mine, to better understand where things went wrong. Also, your popup window after form submission simply redirects to a different HTML page, which isn't the correct approach.

  • P
    AEO•260
    @Jayfx24
    What are you most proud of, and what would you do differently next time?

    Getting a bit better using media query, i know more now than the last project.

    Article preview component

    1
    Dorm-24•200
    @Dorm-24

    Hi AEO, I can't give you a good advice because I myself can't work well with media queries, however I can note some things I've noticed when I went through your code. Firstly, I don't really get why you made all the spacings in custom properties and I think that isn't necessary. Secondly, in the media query: article { display: grid; grid-template-rows: 40% 1fr; height: 60vh ; }, I made it instead of using grid, I used flex-direction: column, and in this way it is way better looking and more responsive. There are a few more small things I could mention but I don't think it will be necessary. Everything else looks good enough!

    Marked as helpful
  • John Gorman•170
    @Johng117
    What are you most proud of, and what would you do differently next time?

    I think I managed to give a good representation of the base designs. Planning the tablet view ahead of time would have saved time.

    What challenges did you encounter, and how did you overcome them?

    I struggled to place the background quotation mark, using z-index. It took a bit of experimentation.

    What specific areas of your project would you like help with?

    Box-shadow, specifically how to implement it better.

    Testimonials grid section

    1
    Dorm-24•200
    @Dorm-24

    Hi, from what I see I can say your solution is pretty good! I like how you've organised your code and its structure. For the box-shadow I also struggled a bit, but I think it ended up great: box-shadow: 40px 60px 48px -48px var(--grey-200);

  • Dorm-24•200
    @Dorm-24

    I really like your solution! I just want to say that you should work a little bit more on the shadows. I suggest you to check out my solution only for them and experiment with it!

  • Ewang Desmond•60
    @Des-cx
    What are you most proud of, and what would you do differently next time?

    i learned responsive design today althoul i'm not yet good at it but with time will try my best to be very good at it

    What challenges did you encounter, and how did you overcome them?

    making the whole page responsive was kind of a struggle to me

    What specific areas of your project would you like help with?

    making it responsive

    responsive product page design

    1
    Dorm-24•200
    @Dorm-24

    You have a lot of mistakes here. It will be hard for me to tell you about all of them, so I suggest you to take a look at my solution and see where your mistakes are. Although my solution is not perfect, I think you can still see where your mistakes are and correct them! Feel free to ask me anything related to my solution if you don't understand something!

  • Dorm-24•200
    @Dorm-24

    It's perfect! I really like your solution and how you've managed to well implement everything! Your code is well structured and readable.

  • Dorm-24•200
    @Dorm-24

    I really like it! I think you should try to be more accurate with the margins and font sizes next time. Everything else looks good enough!

  • Dorm-24•200
    @Dorm-24

    Great job! I really like it, just try to aim for more accurate font sizes, margins, paddings and etc.