@Kingselo
Latest solutions
Latest comments
- @Elyor05
Great job, but:
- your header's word "splitter" in tablet version looks odd, as i saw you forgot adding
line-heighttomedia (min-width: 700px) and (max-width: 1000px) - in images we had logo.svg that we can use instead of making it, i also didn't notice it at start so, i made header also by myself, you can check if you want.
Firstly you can add
line-heightto media queries, to see how it should look, then replace it with logo.svg - your header's word "splitter" in tablet version looks odd, as i saw you forgot adding
- @gracome@Elyor05
Great job, but:
- The only things that can be fixed is tablet view of your website.I see you used media queries, but set
.main { padding: 0; margin: 0; display: block; }which made it looks odd.
Marked as helpful - P@dimitarradulov@Elyor05
Grate job.
- to get rid of colors of the edges just set border-radius of
<div class="card card--${title}">larger that<div class="card__content">…</div>. Set for 2rem, for example.
On the other hand, everything is perfect.
- to get rid of colors of the edges just set border-radius of
- @Ahmed-dark7@Elyor05
Great job, but:
- You should probably work on adaptive design.
- Firstly, you can use 'vh' - viewheight and 'vw' - viewwidth when setting height and width for your element, it will resize based on screen resolution
- Secondly(i suggest this one), you can use media queries, they allow you write css styles for certian devices
// setting css styles for tablets @media screen and (max-width: 769px){ body { display: flex; } }i hope you will keep working
Marked as helpful - @Soliman0100@Elyor05
Good job, everything looks good, but...
- Your images arent loading up, select correct path to your image
- Also sort your files in folder in your github, ut will be easier to understand which file is where, for you and for other people
- @RoelofWobbenWhat are you most proud of, and what would you do differently next time?
I would different that some things are gone in my mind. So I would take a beginners course in css to get into it.
What challenges did you encounter, and how did you overcome them?no real challenges
What specific areas of your project would you like help with?is this site good responsive ? Did I use semantic html well ? Are there other things I could improve ?
@Elyor05Great job.
- You set background-color for the main tag, i suggest you to set it on body tag. Your page will be looking good and without whitespaces around
body { background-color: var(--yellow) }- You have a great responsive design and without using media queries
