mohammed el houssni• 200
@elhoussnimed
Submitted
hello everyone is my try to solve the challenge is good ?
Teru-san
@EstelleRoges
All comments
- Teru-san• 140
@EstelleRoges
Posted
Hi, Your work has a good basis :).
Here are the things I'd like to point out:
-
The use of the details tag is great! But when all the questions are opened, the content goes beyond the white content.
-
I saw you haven't use the mobile version of the images. I recommend you to use them as well as the "picture" tag for automatically switch the image according to the screen size.
-
There is an issue about how the contents are displaying on smaller screens. I also saw in your code that you're using percentages for the image (I'm talking about the mobile version). I also struggled about it and solved the issue by using pixels.
Good luck for fixing all this!
Marked as helpful
1 -
- {"nickname": "JSON"}• 30
@vitor-ramalho
Submitted
Teru-san• 140@EstelleRoges
Posted
Hey, Your solution is nice :). I'd recommend a few things:
-
A better handling of the render on smaller screens, because there's no margin around the advice card starting from a width of 513 pixels.
-
The shadow of the button could be placed more accordingly to the goal design.
-
I saw you cheated with the picture! What you have done is really cool, but maybe you should try working with the actual given pictures. Maybe it would be interesting for you to use the HTML "picture" tag; I heard about it not so long ago and it's a nice option!
Marked as helpful
0 -
