Skip to content
OverviewSolutions
27
Comments
11

símios enfermo

@FernandoChurrosParaná, BR.440 points

Começando a programar, qualquer coisa cultural, sempre codando sobre cultura, e hoje com o maior nome da programação alternativa.

I’m currently learning...

JavaScript

Latest solutions

View more solutions

Latest comments

  • símios enfermo•440
    @FernandoChurros

    Hi @Omrividal 👋, good job completing this challenge! 🎉

    I have some suggestions you might consider to improve your code:

    • The margin in your .card to center is unnecessary as it is flexbox aligning.

    • For lower resolutions, a margin: 2rem on the sides just so elements don't stick to the edges would be more visually pleasing.

    • HTML itself provides option to choose which image will appear depending on user resolution, have a look at documentation picture .

    Above all, the project is done well👏. I hope those tips will help you! 👍

    God job, and happy coding! 😁

  • símios enfermo•440
    @FernandoChurros

    Hi @AmanGupta1703 👋, good job completing this challenge! 🎉

    I have some suggestions you might consider to improve your code:

    • When scrolling with the navigation bar open it just disappears, a position: fixed would be a better choice.

    • In tablet resolution (768px) the page does not behave the way you want, in this situation a more accessible approach would be to use flexbox.

  • símios enfermo•440
    @FernandoChurros

    I have some suggestions you might consider to improve your code:

    • To center content, you can use flexbox on the parent of the element you want to align, using the display: flex and align-items: center (aligns the element on the transverse axis), sets a height: 100vh to always center in relation to the user's screen.
    Marked as helpful
  • símios enfermo•440
    @FernandoChurros

    I have some suggestions you might consider to improve your code:

    • In the body could set a width: 100vw, so the card is always centered regardless of the user's screen resolution.

    • The use of the strong tag is to give 'great importance', including urgent things (like alerts), to apply a style it is recommended to use 'font-weight`, in CSS.

    • For styling, use classes for better code maintenance, if you need to change something in the HTML, your CSS will break, as it is tied to tags.

  • símios enfermo•440
    @FernandoChurros

    I have some suggestions you might consider to improve your code:

    • center tag has been discontinued, for centralization I recommend using flexbox in the parent element of those who want to centralize, setting :
    height: 100vh;
width: 100vw;
display: flex;
justify-content: center;
align-items: center;
    • The value you specified in the font-weight property is invalid, have a look at documentation to know what values this property accepts.
    • The font-size must be specified in a unit of measurement (px, rem, em).
  • símios enfermo•440
    @FernandoChurros

    I have some suggestions you might consider to improve your code:

    • A better way to center the content is to use the display: flex;, align-items: center; and justify-content: center; properties of the Flexbox in the body by setting a height(100vh) and width( 100vw).

    • Putting the background as img in the body is not semantically recommended, it's just a background and not a page content.

View more comments