Skip to content
OverviewSolutions
6
Comments
2
FiliC
@FilipCondac

All comments

  • FiliC•160
    @FilipCondac

    The problem with your code is you need to address the <a> element and not the <svg> , like so:

    footer a:hover { styles.... }

    Also I recommend putting the SVG code in a .svg file as it makes it easier to read!

    I checked you GitHub out and you have a massive repo with all your projects. I recommend making individual repos for each project and committing small blocks of code. This makes it much easier to see and follow your progress on larger projects, also of course allows for easier rollbacks!

    Good luck in your learning journey!

  • FiliC•160
    @FilipCondac

    Good job! Good and clean code also easy to read!

    In your JavaScript you should be using “const” rather than “let” for variables that don’t get reassigned in the future. In your case you can do this for things such as your function declaration and Query selectors. These things will always be the same thing, a function or a query selector! In this small example it doesn’t matter much as efficiency isn’t a problem but it is good practice for future larger projects!

    Good luck!

    Marked as helpful