Skip to content
OverviewSolutions
5
Comments
6

George_alex

@GeorgeCaldarescu140 points

Self-taught front end developer student with a Biology background

I’m currently learning...

Improve my responsive design and learning JavaScript

Latest solutions

Latest comments

  • George_alex•140
    @GeorgeCaldarescu

    Hi! try to center the container div, especially on mobile version. If you give it a width you can set margin to auto and will automatically center. In this way you will also remove the little overflow you have in the mobile version. Hopefully I gave you a good advice, I'm also learning.

    Cheers

    Marked as helpful
  • George_alex•140
    @GeorgeCaldarescu

    Quick question. Why are not using flexbox here?

    George

  • George_alex•140
    @GeorgeCaldarescu

    Hi. Regarding the social icons, try to use this format and will easily work style it with flexbox

    <main class="main-container">
        <img mockups.svg>

      <div class="text">
        <h1> Title       </h1>
        <p> text     </p>

        <button></button>

         <div class="social-links">
          <a> </a>
          <a> </a>
          <a> </a>
        </div>
      </div>
    </main>

    Some other suggestion:

    • start with mobile style, will be easy to work and then when you are going to create the desktop one you need only a few changes
    • pay attention at the text in mobile version, is not easy to read
    • the social icons must be a link and not list

    Good luck!

    Marked as helpful
  • George_alex•140
    @GeorgeCaldarescu

    Hi! Some advices, I'm not an expert but I start to write my HTML cleaner and your looks ok from my opinion. Try to start to work on the mobile version first, as you will see the divs will automatically arrange on columns, and then move on the desktop part you will have. I suggest you the Kevin Powell CSS course on responsive designs (is free), he's focusing more on the flexbox. If you like you can also have a look at the 2 courses of Wesbos regarding flexbox and grid.

    The nav menu is a nice add, but you can use white color so can popup better, and on mobile version try to put the hamburger menu, even if is not working.

    Cheers

    Marked as helpful
  • George_alex•140
    @GeorgeCaldarescu

    Hi! Great solution, responsive website but I would like to give some advice. I'm still in the beginning but maybe you will find it useful.

    • the text at 375px is too small, try to make it bigger.
    • use links for the social icons, and not only the icons
    • try to change the background image when you switch from desktop to mobile

    George

    Marked as helpful
  • George_alex•140
    @GeorgeCaldarescu

    Hi! Looks good, but the social images should be a link and not only an icon. I would like give you the same advice I received in the first challenge, buttons should be used in forms or to open some kind of menu, is better if you use a link, and then you can style it like a button.