Guido Aranda• 120
@GuidiUZ
Submitted
Another challenge finished. Implementing a bit of grid, flex, and others. I appreciate the feedback.
Gerri Ezeocha
@GerriEzeocha
All comments
- Gerri Ezeocha• 460
@GerriEzeocha
Posted
Well done Guido! My suggestion is to check your 'snippet'( your class name seems to thirdtext) section again. your text content is off. I don't think you need those span elements in there. Also it is recommended to use the 'div' element to generally group content for styling specifically while 'section' markup simply helps with the 'outline of a page.
keep up the good work.
Marked as helpful
0 - Gerri Ezeocha• 460
@GerriEzeocha
Submitted
Gerri Ezeocha• 460@GerriEzeocha
Posted
Any feedback is welcome (especially page view on different screens)! it seems fine everywhere else, but preview on frontendmentor seems off on the bottom.
0 - anasselhaoussi• 70
@anasselhaoussi
Submitted
When I want to scale the card on hover, the screen increase its size which make it looks a bit ugly i don't know how to fix it !
Any suggestions ?
Gerri Ezeocha• 460@GerriEzeocha
Posted
Not sure what you mean, but have you considered using css animation to 'transform' on hover? that way you can set the height and width you want!
0 - Nakoya Wilson• 1,530
@nakoyawilson
Submitted
Any suggestions on how I can improve are welcome!
Gerri Ezeocha• 460@GerriEzeocha
Posted
This looks good, well done! I noticed you used 'SVG/paths' and 'Picture/src' in your html, why was this your approach and what benefits do they provide?
Keep up the good work.
0 - Eugi• 270
@EugiSs
Submitted
Hello. I tried to make the page through mobile-first. I'm not very good at responsive layout yet. I made styles for 375px and 1400px only, no smooth transition. I look forward to any comments and criticism. Thanks
Gerri Ezeocha• 460@GerriEzeocha
Posted
Your desktop layout looks good, but review your responsive designs and display for mobile. As for your question the main difference I believe is that <section> is more generic tag, while <article> is more specific. check out usage notes on when to use either on https://developer.mozilla.org/en-US/docs/Web/HTML/Element/section
Marked as helpful
0 - Elijah Oyerinde• 40
@elijahthis
Submitted
Hii. I'm trying out responsive design for the first time. Any feedback would be appreciated. Thanks.✌
Gerri Ezeocha• 460@GerriEzeocha
Posted
This looks great Elijah! and responsive design is well done :)
0 - Cường• 845
@docuong0912
Submitted
I would like some reviews,advices about my design and code, thank you guys so much :3
Gerri Ezeocha• 460@GerriEzeocha
Posted
Looks like you're missing your main hero section! I was looking through your src and public files and cant seem to identify the issue.
1 - Elisa• 50
@elisa-charrier
Submitted
At the beginning of each project, I am always undecided about which are the smartest names to give to the classes. Any suggestions? I'd be happy to check out any alternatives to the script I wrote: I'm not a pro in Javascript. Feel free to report me your solution! Thanks to who will answer.
Gerri Ezeocha• 460@GerriEzeocha
Posted
Great Work! Your question got me looking at naming conventions myself and it seems the BEM way is a good way to go!
Marked as helpful
0 @JuaniCaste23
Submitted
Using Flex is good practice! It was made as the design was, with its respective states and with the responsive design. An eye was also added to hide or activate password text. Totally happy with this exercise !!
The feedback is very appreciated!!. Thanks.
Gerri Ezeocha• 460@GerriEzeocha
Posted
Very well done Juan! I myself will be starting this exercise soon and looking forward to it :)
Marked as helpful
1- Williams Samuel• 320
@williamssam
Submitted
Feedback will be greatly appreciated especially on the responsiveness of the site.
Thanks.
Gerri Ezeocha• 460@GerriEzeocha
Posted
Looks good William, great job! my comments would be watch the positioning of some text elements on active slides. keep up the good work!
0 - Vishal Nirmal• 560
@vishalnirmal
Submitted
Gerri Ezeocha• 460@GerriEzeocha
Posted
Love this sir! your Javascript is simple and efficient.
1 @jun-edris
Submitted
My Javascript code is messed up. How can I get it more readable and short?
Gerri Ezeocha• 460@GerriEzeocha
Posted
Great work Juanire! What issues are you having with with your Javascript? On your preview site the toggle function is working! In terms of shortening your code, perhaps use css to change your mobile/share section and simply work on displaying with Javascript. :)
0- Alex• 310
@AlexGanderton
Submitted
I feel these challenges are starting to get a little easier as I keep going due to the practice and the change in approach by going mobile-first. Life saver! any newbie who hasn't tried it yet please give it a shot!
Gerri Ezeocha• 460@GerriEzeocha
Posted
Oh nice tip Alex! will try mobile first on my next challenge!
0 - Gorkem Basbug• 310
@gbasbu
Submitted
How to make it better? Your feedbacks are most important to me. Thanks.
Gerri Ezeocha• 460@GerriEzeocha
Posted
Gorkem you did great on this! my only feedback would be to add some transition/box-shadow on hover states of 'learn more' buttons.
Bravo!
0 - Adri• 90
@adridwk
Submitted
Hi Everyone
Any feedback would be appreciated.
Many thanks Adriana
Gerri Ezeocha• 460@GerriEzeocha
Posted
Great job on your second shot. Also your mobile "about/why us' section isn't visible. double check your mobile styles!
keep up the good work!
0 - PRaj Cutinha• 870
@RajCutinha
Submitted
Gerri Ezeocha• 460@GerriEzeocha
Posted
Well done Raj! I noticed you did not use css grid for the entire page, did this approach give you more flexibility?
keep up the good work!
1 @NelsonBaileyIII
Submitted
Let me know how bad I did! Criticism always welcomed. Seriously.
Gerri Ezeocha• 460@GerriEzeocha
Posted
How bad you did?? Ha! Not bad at all, looks good! (Reading your code, I notice you're using a color, instead of the background svg file provided, perhaps try a linear gradient using your variable colors)
Keep up the good work!
0- Whitegod Kingsley• 450
@iamwhitegod
Submitted
Any suggestions or feedback would be greatly appreciated!
Thank you and happy coding :)
Gerri Ezeocha• 460@GerriEzeocha
Posted
This looks good Kingsley, Well done! I did notice you were missing the quotation mark by testimonials and social icons in your footer! (svgrepo.com or iconmoon.io, has free icons, if those were not included with the files!)
0 - Krishna• 195
@krishna-nayak
Submitted
Give me any feedback about this challenge.
Gerri Ezeocha• 460@GerriEzeocha
Posted
Great Work Krishna! Really great how you built it all out with CSS-grid, currently learning that myself!
0
