Skip to content
OverviewSolutions
10
Comments
7
Griselda Knight
@Greeshma2903

All comments

  • Griselda Knight•280
    @Greeshma2903

    Hey Soransh!

    Nice work, but you have scope for improvement 😊. I am no expert, but being part of this community, I'll be happy if I could be any help!

    First up, you can clear the Accessibility and HTML issues that have been pointed out 👆. I think your main focus with this project was on CSS and not the functionality (through JS) because while clicking on the button, the page got redirected, instead of a page reload.

    With regard to your code, I recommend using shorthand property over specific properties (increases readability), for eg : instead of padding-left: 30px; padding-right: 30px; padding-bottom: 6px; you can use, padding : 0px 30px 6px

    Good work with the background there! Happy coding 😄👍

  • Griselda Knight•280
    @Greeshma2903

    Good work with the design,

    • you can add some more margin top and bottom margin to the .container, for a cleaner look
    • maybe you can add overflow: auto to container, to enable the scroll option for smaller screens. Happy coding! :)
  • Griselda Knight•280
    @Greeshma2903

    Good start with Bootstrap!

    You can add a class to container-fluid, and add some margin to the page, to make it look cleaner.

    happy coding!!

  • Griselda Knight•280
    @Greeshma2903

    Good one!

    keep going!!

  • Griselda Knight•280
    @Greeshma2903

    the site is quite responsive! Good one. Keep going! All the best!

  • Griselda Knight•280
    @Greeshma2903

    That's a really cool hover effect on the buttons!

  • Griselda Knight•280
    @Greeshma2903

    Hello! You can add some margin to the body, to make it resemble the given design a bit more.