@bhargavjyoti
Hey there fellow coders, I am Sankalpa Sarkar but you guys can call me Sankalp . I am over here to learn lots and lots about coding especially front-end dev. I am grateful to share my coding journey with all of you guys.
I’m currently learning...Currently I am learning a lot about front end devs like :- Html, css, Javascript, es6, React, React Native, usage of third party api. Also recently I learnt about a version control system called git. I will continue to increase my knowledge about all of this stuff
Latest solutions
Latest comments
- @IllusiveCoder1101
Firstly, congrats on completing the challenge . Now to answer your question whether you should keep the sass file or not. Answer:- Yes, Reason (If you remove the sass file, other people who view your code on Github, won't be able to know if you used sass or not).
I noticed a few accessibility issues , to remove them use <main class='card' role='main'></main>, it should fix it. That's all :)
Marked as helpful - @Ehab-Elshahat@IllusiveCoder1101
Firstly congrats on completing the challenge , it wasn't an easy one. I noticed a few problems with your site:- 1.The step numbers present on the nav-bar/side-bar aren't meant to be buttons , their only purpose is to show the Active step. If treated as buttons , there would be no point of the next and the back buttons. 2. The site appears broken on my desktop, each of the sections are overflowing, so try testing it on all the screen provided on the console. 3.It's not dynamic , the site is clearly static, even when I choose a different plan , it's not updated on the confirmation page. 4.For the Accessibility error, try replacing the <h4/> tags with <h1/> tag. (Also there's a typo on the first page , you wrote "Pleas" ) That's mostly all :)
- @Hassan-Wanas@IllusiveCoder1101
You have to use the background-position property of the cuss to position those background images.
- @aatifsohel@IllusiveCoder1101
For the inner divs of the card component you can use header for the first then the body tag and bottom part with the footer tag..
- @aatifsohel@IllusiveCoder1101
The code looks great overall , to make the code even better you can try using semantic HTML tags like :- <header/> , <nav/> , <section/> etc. This would make your code more readable , rather than using so much divs. Otherwise you were spot on the final result looks great. Keep up the great work!!!!
- @Eminentdio@IllusiveCoder1101
Congrats on completing the challenge, about the mobile display issue, I think you should look into css media queries which is responsible for display on different screen sizes. Keep up the great work!!!!
Marked as helpful
