@neekaisweird
Latest solutions
Latest comments
- @InterplanetaryDragon
It was good reading your CSS code. When I did this challenge (first one I've done) I used CSS grid too, but for desktop, tablet and mobile. In hindsight, I think I'd have used Flexbox (which I've use on the last two sites) for mobile and tablet then the grid for desktop. It was my first time doing a site and using CSS grid so I wanted to practice. Your code was interesting to read as it was different to mine. I used grid-template-areas instead of selecting column and rows lines. It's nice to see other ways to implementing it. Thanks for sharing.
- @anthonyPassler@InterplanetaryDragon
Also just noticed, your buttons don't seem to be buttons. Are they a tags with a background and border? Cool little solutions really. No difference visually speaking.
- @anthonyPassler@InterplanetaryDragon
Page looks great! That very minor HTML issue that has popped up is because you have a section without a heading. I checked the code and you used <section> several times. In most cases you'd be better off with a div, especially if there isn't a heading as it'll flag up.
It's just one of those things... you'd think it shouldn't really matter, which it shouldn't. I'd argue that logo area is a section, but a HTML checker will want it as a div. Semantics!
- @MeFredj@InterplanetaryDragon
Hi Frederick, site looks good. I tried to check the code to see what the errors are (2 accessibility and 4 HTML) but the code seems to be for a different design.
It looks like the errors are saying you have used the same ID more than once. You cannot use the same ID more than once. IDs are individual, therefore if you are going to use it more than once you should create a class. Here is a good link: https://css-tricks.com/the-difference-between-id-and-class/
Only thing U can see visually which you could improve is using font weight 200 for the heading 'Reliable, efficient delivery', as the current font-weight is too heavy.
If you want to learn more about CSS Grid I recommend this video and code to go with it:
https://www.youtube.com/watch?v=7kVeCqQCxlk https://codepen.io/mor10/pen/NjeqyX/
Also, check out this short and free course. It has some useful tips: https://scrimba.com/playlist/pWqLHa
Good job!
- @xavirepi@InterplanetaryDragon
Hi Javier, looks good on desktop. The site doesn't appear properly on mobile or tablet. I'd recommend reading up on CSS Grid and Flexbox for laying out your design. If you Google Scrimba and then search their site for both CSS Grid and Flexbox, they have free short courses for each. Less than an hour each and are very useful. There is also lots of material on W3 schools, Mozilla MDN and CSS tricks. Hope this helps.
- @kkmitra@InterplanetaryDragon
Great job! The boxes are slightly different heights on mobile. You could add a fixed height to them. Or use the minimum height feature. Or a fixed height for different media.
