@Cauathiago
JamesYcode
@JamesYcodeAll comments
- @JamesYcode
Wow! Great job! Love the added light - dark mode feature along with other features!
- @MatthewPCopeWhat are you most proud of, and what would you do differently next time?
I'm proud of the javascript functionality. and the responsive design.
What challenges did you encounter, and how did you overcome them?Getting the icons in the right position was tough. I still didn't get them perfect but I tried a whole bunch of stuff to fix it and just eventually had to move on.
What specific areas of your project would you like help with?The icons. Getting the icons in the right spot. If anyone could help me out with that I'd appreciate it.
@JamesYcodeWow! Great solution for JavaScript section! I loved how you approached this! I had to refactor my entire script file to your method with some minor changes. It is very easy to read and understand.
Thank you and great job!
- P@barka-dev@JamesYcode
Wow! Very nicely done!
- @Mohamed-ben-Ali@JamesYcode
Great solutions for your layout using flexbox method. One thing I can point out is the responsiveness for mobile and larger desktop screen should be in sync with the laptop viewport sizes. I can recommend going for mobile first approach and then to desktop to make it more responsive instead of desktop to mobile. I also liked how you used very little code to achieve this! Great job!
Marked as helpful - @HASSNAAM@JamesYcode
Great effort and great job! Only thing I can suggest is have the right text contents align center if height isn't set. Or maybe you can give a specific height to match the image on the left, therefore the outcome would be more pixel perfect.
I really like how you matched the image to be exactly like the design wireframe. Great job!
- @Chirtoaca94What are you most proud of, and what would you do differently next time?
Working with the DOM to manipulate the success message and newsletter page.
@JamesYcodeGreat job on the custom transition when submitting the form! One thing I noticed was that after form validations had triggered and clicking the dismiss button, the validations errors is still there in the DOM.
I encountered a similar issue and resolved it by assigning a custom class to the validation error element. Then, I set its display property to 'none' when the dismiss button was clicked.
Marked as helpful - @Jack-OCWhat are you most proud of, and what would you do differently next time?
I found it initially very tricky to use the CSS position property to position the tooltip element, so tested the property until I had a better understanding of it.
What specific areas of your project would you like help with?I think my solution may be a bit messy, any suggestions to improve it would be greatly appreciated.
@JamesYcodeVery well done! I like how you've made the share button share states in both desktop and in mobile.
