@lotfy1654
Jean
@JeanMiesesAll comments
- @JeanMieses
Hey brother. There are a few things you should fix. The "product-section" should be centered vertically. Add a working "Cart' component as well, so when I click add to cart button, it adds the product to the cart. Also, when I click to add quantity or decrease, the adds to cart button moves. I think it is cuz the padding. I feel that is something you should look into.
I love the design. It is way better than mine. I missed the cart image in the add to cart button as well. And how did you implement the carousel? I used a library for it called Splide cuz coding it on my own would have taken a bit of work and I am too lazy. Your carousel looks amazing.
here is my project https://www.frontendmentor.io/solutions/ecommerceproductredux-dei3tJbWL
- @vishalbrdr@JeanMieses
Hey man, it looks great. Just one suggestion. You should organize your file a bit better. You have your .JPG images in the same folder as your CSS and js files. I feel it would be better if you create a folder 'images' or something like that and add all your images there. Great job btw. I will try to do the same soon since I just learning react.
Marked as helpful - @annacsillaxs@JeanMieses
hey anna, the design is great, but when I click any of the planets on the top, the page does not update to the planet I clicked on. You should definitely look into that. That is the main challenge. Also, if you could push your code to github, we will appreciate it lol.
- @yasssuz@JeanMieses
everything looks good. There is a , between some off these labels.
- @otmanezahhari@JeanMieses
There is an issue where I can't add comments in any post. The road map and the buttons to filter posts go away when you are on mobile devices. When I open a specific post and try to refresh, I get a 404 error... It is probably a GitHub pages bug. Other than that, it looks amazing.
- @Andrii-Rohov@JeanMieses
Man, amazing work! The only thing I would suggest you do is to use sections more often instead of divs. But this is great!
Marked as helpful - @ScottGrun@JeanMieses
Man, I love the 3D effect when you click the surface of the planet. I read a bit of your code and even for a amateur like me, I was able to understand what each component does. The only thing I would change is the planet size for desktop. I feel it is a bit small... How did you get that 3D effect? Lol I wish I would have used something like that on my project.
Marked as helpful - @mewebbie@JeanMieses
Great job Bro. I took a quick look at your code. It looks pretty clean. My only suggestion is don't use var when creating a variable. Instead, use let or const.
- @mohamed7799@JeanMieses
Hey, great work. The only thing I would do is add a bit of margin between the "Full access for less than $1 a day" and the signup button.
Marked as helpful - @charlottesaidi@JeanMieses
Hey on my desktop, the background is not covering the entire page. It is about 50% width and height as well. Here is an image https://ibb.co/vDKdLmH
It looks fine on mobile.
Marked as helpful - @seanred360@JeanMieses
Man, I am working on the same project and I love what you did here. I also took a quick look at your code, and I am so jealous lol. Way better than mine. I hope to be as good as you someday. The only thing I would try to change from your code is to move the planet array to a separate file and then require it to main.js. BTW, I will try to use anime.js as well on my project.
- @JeanMieses@JeanMieses
I realized I missed the symbol on the top of the page, lol oh well.
- @JeanMieses@JeanMieses
I did not realize the layouts issue until I opened it on my phone as well lol. I will work on the design. Thanks for the advice man!
- @Eldaernth@JeanMieses
I am curious how long did it take you to finish this? I am working on this challenge. I already got the basic functionality down using vanilla JS. But, I saw your code and it was way cleaner than mine. Btw, it looks great man!
