@Macstork
I am a front-end developer currently studying the MERN stack. In my spare time I enjoy being outdoors with my family and 2 dogs as well as solving problems, I’m passionate about software development and I’m looking forward to meeting new people and getting to work on new projects in the near future.
Latest comments
- P@JordanPhillips-hub
Hey Maciej I like your solution a couple of things I would consider changing is there should only be one <h1> tag on a page I would change this and use a span like this to avoid using two <h1> tags <h1 header__title> Reliable, efficient delivery <br/> <span header__title--dark>Powered by Technology</span>
</h1> Also, consider changing your <h3> tags to <h2> tags and adjusting the font size with CSS as heading levels should increase by one for accessibility reasons. - @yourpaldiggyP@JordanPhillips-hub
Hey Anthony try using a <main> tag instead of a div on your bg this will give your page a main landmark as you have none in your HTML, also try using a h1 instead of an h4 and just adjust the font size to what you want your first header should be an h1 for accessibility reasons..
Marked as helpful - @AmmarCodeP@JordanPhillips-hub
hey Ammar the card looks good although I am not sure if you are getting HTML tags and classes mixed up you should remove the <container> and <card> as these are not tags try wrapping them with a <div> </div> and giving them a class like this <div class="card"></div>, <div class="container"></div>, if you wished to you could remove those altogether as you already have your <main> tag as a wrapper and do not need the other two.. hope this helps you. Here is a good source about HTML tags and when to use them.
- @herreranicolasP@JordanPhillips-hub
Looks good.. one other thing you could do on this is to switch the h2 to a h1 and change the font size to font-size: 1.375rem; this will get rid of the rest of your accessibility issues. Generally, it is a best practice to ensure that the beginning of a page's main content starts with a h1 element, and also to ensure that the page contains only one h1 element.
Marked as helpful - @herreranicolasP@JordanPhillips-hub
Try putting the blueish grey background colour on your body instead of the .container this should fill make the whole page that colour and get rid of the white patch at the bottom.. Looks good though.
Marked as helpful - @95FredoP@JordanPhillips-hub
Align items controls the cross axis when flex direction is row that is up and down, justify content controls the main axis witch is left and right, try using justify content: flex-end.. the axis will be reversed when flex direction is column cross axis left and right main axis up and down.
