@Geoff-Walker
Submitted
Would really welcome some feedback specifically on the javascript as this is my first attempt using it on Front end mentor.
Looking to hire developers?
@Jos02378
@Geoff-Walker
Submitted
Would really welcome some feedback specifically on the javascript as this is my first attempt using it on Front end mentor.
@Jos02378
Posted
Hey @Geoff-Walker, good job on this solution!
Some suggestions for you:
min-height
or not setting the height at all so the element can grow as the content grows.I hope this helps, good luck!
@satyamallick7
Submitted
I'm a newbie so please excuse the mess
@Jos02378
Posted
Hey @satyamallick7, good job on this solution!
Some suggestions for you:
text-transform: uppercase
to capitalized text in CSS.min-height
or not setting the height at all so your element can grow as your content grows.I hope this helps, good luck!
Marked as helpful
@ChitThetAung
Submitted
Hello guys! Please suggest me about my solution .Thanks you.
@Jos02378
Posted
Hey @ChitThetAung, great job on this solution!
Some suggestions for you:
main
element to wrap your code in the body to clear some accessibility issues in the report.I hope this helps, good luck!
Marked as helpful
@nas096
Submitted
Are there any ways to improve this solution?
@Jos02378
Posted
Hey @nas096, good job on this solution!
Some suggestions for you:
max-width
to your main tag to keep the structure and shape of your card when the size of the screen is getting bigger.footer
tag to clear the accessibility issue in the report.I hope this helps, good luck!
Marked as helpful
@Nathan-Front
Submitted
Any suggestion to make it better will be helpful in learning. Thank you
@Jos02378
Posted
Hey @Nathan-Front, good job on this solution!
Some suggestions for you:
text-transform: uppercase
to capitalize text in CSS instead of typing them in HTML.img
tag and a div like in this video overlay video.I hope this helps, good luck!
Marked as helpful
@Jxai00
Submitted
I'd love to get some feedback on my solution. Feel free to talk about where can I improve.
@Jos02378
Posted
Hey @Jxai00, good job on this solution!
Some suggestions for you:
text-transform: uppercase
to capitalized text in CSS instead of typing them in HTML.max-width
to your container so that you can keep the structure and shape of the card if the screen size is getting bigger.I hope this helps, good luck!
Marked as helpful
@omerome83
Submitted
Any feedback would definitely be appreciated.
@Jos02378
Posted
Hey @omerome83, good job on this solution!
Some suggestions for you:
background-size: cover;
and background-repeat: no-repeat;
so the image can cover the container without being duplicated for IPad size.I hope this helps, good luck!
Marked as helpful
@egemendemir
Submitted
Feedback is appreciated. If there are any mistakes or bad practices in the code please let me know.
@Jos02378
Posted
Hey @egemendemir, great job on this solution!
Some suggestions for you:
text-transform: uppercase
to capitalized text in CSS instead of typing them in HTML.I hope this helps, good luck!
Marked as helpful
@pccipri
Submitted
I would appreciate if you could tell me what you think about my solution.Let me know if u have any advice regarding accessibility or responsiveness. I'm a beginner so any advice is welcomed. Anyway thanks for taking the time to view my solution.
@Jos02378
Posted
Hey @pccipru, good job on this solution!
Some suggestions for you:
text-transform: uppercase
for capitalizing text in CSS instead of explicitly typing them in HTML.min-height
or not setting the height at all so the card can grow as the content grows.I hope this helps, good luck!
Marked as helpful
@VaNaChiMa
Submitted
I would appreciate any feedback, thank you in advance.
@Jos02378
Posted
Hey @VaNaChiMa, great job on this solution!
Some suggestions for you:
text-transform: uppercase
to capitalized text in CSS instead of explicitly typing them in HTML.I hope this helps, good luck!
Solution updated, fixed the vertical align of the main component. Feel free to give any tip about the solution, would help me a lot.
@Jos02378
Posted
hey @JSaporski , great job on this solution!
Some suggestions for you:
<h2>10k+ <br><span>companies</span></h2>
instead.div
just like in this video overlay video.I hope this helps, good luck!
Marked as helpful
@obaryo
Submitted
Any feedback will be much appreciated
@Jos02378
Posted
Hey @obaryo, great job on this solution!
Some Suggestions for you:
<h1 class="name">Victor Crest <span>26</span></h1>
and then style the span.I hope this helps, good luck!
Marked as helpful
@yasser22269
Submitted
Please leave some feedback! :)
I would really appreciate it!
;)
@Jos02378
Posted
hey @yasser22269, great job on this solution!
Some suggestions for you:
object-fit: cover;
to prevent the image from being squeezed and use object-position
to position the image.mix-blend-mode: multiply;
to achieve a similar overlay for the image.I hope this helps, good luck!
@nottohave
Submitted
I am not good at using Javascript. My issues are not enough the whitespace at the bottom when multiple answers are selected in both desktop and mobile view. The other one could be the design how the card is not center at the begin of any screen size. This looks okay on 375px and 1440px width screen. Any other will not center the card. Let me know what else I can learn. Thanks!
@Jos02378
Posted
Hey @nottohave, good job on this solution!
Some suggestions for you:
min-height
or not setting the height at all so your card can grow as your content grows.margin: 0 auto
.I hope this helps, good luck!
Marked as helpful
@wanaz13
Submitted
Hello guys..i really need you help..why did my image i put in css did not display..i double check the root file image is correct but the image did not appear...i need a solution ..thank you guys
@Jos02378
Posted
Hey @wanaz13, good job on this solution!
Some suggestions for you:
../images/image-header-desktop.jpg
.justify-content: space-between
to spread your stats element.I hope this helps, good luck!
@ebbscode
Submitted
Second project completed, I believe i can't get the design height correctly need feedback on that. Any input will be highly appreciated.
@Jos02378
Posted
Hey @ebbscode, good job on this solution!
Some suggestions for you:
I hope this helps, good luck!
Marked as helpful
@R0b3rtG
Submitted
Hi, I had very much fun making this web page.
I encourage you to try it too if you didn't already :)
I managed to make it responsive for every single device using the mobile-first method.
Hope you like it!
And please give me some feedback:
All the best! :)
@Jos02378
Posted
Hey @R0b3rtG, good job on this solution!
Some suggestions for you:
main
tag a max-width
to keep the structure and shape of the card.I hope this helps, good luck!
@Olabayoji
Submitted
Any suggestion would be highly welcome. Thank you in advance.
@Jos02378
Posted
Hey @Olabayoji, good job on this solution!
Some suggestions for you:
text-transform: uppercase
to capitalized a text in CSS instead of explicitly typing the in HTML.I hope this helps, good luck!
Marked as helpful
@bcr95
Submitted
I had a little less problem with the mobile design than the second one.
@Jos02378
Posted
Hey @bcr95, good job on this solution!
Some suggestions for you:
border-radius
and change some of the icons with the appropriate one.I hope this helps, good luck!
@MartinaWebDev
Submitted
Hello guys, I am at the beginning of learning web development so any feedback on this code is appreciated. Tips and Tricks are welcome. Thank you :)
@Jos02378
Posted
Hey @MartinaWebDev, good job on this solution! I see that your solution is not responsive yet, looking forward to seeing it.
Some suggestions for you:
text-transform: uppercase;
to capitalized text in CSS instead of explicitly typing them in HTML.div
by watching this video overlay video.I hope this helps, good luck!
Marked as helpful
@ZainMhrez
Submitted
This is my solution for Profile card component challenge from Frontend Mentor website using flexbox. I'll be happy if you have any feedback.
@Jos02378
Posted
Hey @ZainMhrez, good job on this solution!
Some suggestions for you:
hsla
instead of var so you can play with the opacity and match the design.I hope this helps, good luck!
Marked as helpful
@K-ash-ish
Submitted
I came across many hurdles I overcome some of them. But still, I am unable to make it look like the final design. But I learned many things and also any suggestions are helpful because I want to make it look like the given design. The mobile part looks good I think😅 the desktop image part is what I really struggled with.
@Jos02378
Posted
Hey @K-ash-ish, good job on this solution!
Some suggestions for you:
max-width
for your card so you can keep the structure of the card if the size of the screen is getting bigger and bigger.position: relative
to your card so you can position your box based on the card, not the screen.I hope this helps, good luck!
Marked as helpful
@myatthu000
Submitted
any feedback is appreciated.
@Jos02378
Posted
Hey @myatthu000, good job on this solution!
Some suggestions for you:
text-transform: uppercase
to capitalized text in CSS instead of explicitly typing them in HTML.main
tag.I hope this helps, good luck!
Marked as helpful
@fangyinglim
Submitted
any feedback to improve my code is greatly appreciated!
@Jos02378
Posted
Hey @fangyinglim, good job on this solution!
Some suggestions for you:
main
tag to clear some issues./images/icon-sedans.svg
because it doesn't load on the website.min-height: 100vh;
or not setting the height at all so the container can expand as the content grows.I hope this helps, good luck!
Marked as helpful