Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P

    @joeterlecki

    Submitted

    Here is my second solution and I incorporated the feedback from my first challenge.

    My question would be, how would you change the dynamic photo for responsive design? In this case, a second image was provided and the only way to do it with an img src tag was to use srcset and put the media queries in HTML. To me, this seems like an anti-pattern as those breakpoints and image changes should be in the CSS styling. But that brings another issue to me. If you define an image in background styles in a div, then what's the appropriate way to apply alt values for accessibility?

    @Josemario17

    Posted

    you can change it by screen size using the picture tag incorporated with the source tag and then the img tag, see this at: https://www.w3schools.com/tags/tag_picture.asp

    keep on

    0
  • @IsraeliPS

    Submitted

    I think it was a fairly simple project, made with SCSS and React that facilitates modularization

    I appreciate any comments or suggestions for improvement

    @Josemario17

    Posted

    Good job, for this solution my suggestion is the following: increase the height of the container or decrease its width, to make it as square as possible, I hope I helped.

    enjoy the code

    0
  • @Josemario17

    Posted

    great work, but it isn´t in center viweport

    1