Skip to content
OverviewSolutions
13
Comments
9

Julian Köhler

@JulianKoehlerHannover, Germany430 points

I like to develop progressive Web Apps Frontends with React and Typescript

I’m currently learning...

React, Typescript

Latest solutions

View more solutions

Latest comments

  • Julian Köhler•430
    @JulianKoehler

    I like that you are reducing the categories from the data! This exactly is following the open-closed principle. However I would have liked if you included for instance a firebase database for storing the order, maybe generating an order confirmation number which is sent back to the customer :)

    Marked as helpful
  • Julian Köhler•430
    @JulianKoehler

    I really like your eye for details in design. It feels very smooth and you really translated the design well. I also like your firebase solution. But your filter function is a bit weird. Instead of forcing the user to search for the exact job title, consider filtering the job listings with either .contains() or .startsWith() and consider adding tags to the job objects like experience wanted and technologies needed. And don't forget to make everyting .toLowerCase() in the function. That way I think you can inmporve the filter function.

  • Julian Köhler•430
    @JulianKoehler

    Wow this one is insane! I am really hyped about your animations and sound effects, did you use react-reveal for that? Did you manage to play an audio once the timer is expired on mobile browsers? Unfortunately I already heard that mobile browsers only support audio on user events so the soundeffect when the timer ran out won't play. Would you mind having a look around my code on this project? You seem to have experience.

  • Julian Köhler•430
    @JulianKoehler

    Hey, great job, this project wasn't easy. But I have found 2 bugs with which I also struggled: I am able to enter negative timers and if applied the app crashed completely and I am only able to use it again if I clear my localStorage from the console. I guess an average user would not be capable of that. And the second thing is that I can change the phase while the timer is running. I have implemented a Modal asking the user if he really wants to skip this phase and then resetting the timer and clearing the Interval. Check out my solution if you like to.

    Marked as helpful
  • Julian Köhler•430
    @JulianKoehler

    Great! I could almost guess you have watched the Web Dev Course from Angela Yu on Udemy? :D I did as well and she taught EJS in combination with Express, great work.

  • Julian Köhler•430
    @JulianKoehler

    Awesome! I love your animation on the color theme button. But I think you are missing the content property on the job details page, you are only showing the bullet points.

View more comments