Lara Fernanda• 400
@Lara123-pg
Submitted
Hey guys, this is Time Tracking Dashboard project and i would like feedbacks about the code to contribute with next projects. Thank you.
Kasra Tabrizi
@KasraTabrizi
All comments
- Kasra Tabrizi• 300
@KasraTabrizi
Posted
I like how you structured your files for this project.
The only small improvement you can make is to try to center your container. Other than that, good job!
Marked as helpful
0 - 👾 Ekaterine Mitagvaria 👾• 7,640
@catherineisonline
Submitted
Hello, Frontend Mentor community! This is my solution to the FAQ Accordion Card.
I appreciate all the feedback you left that helped me to improve this project. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.
You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.
Thank you
Kasra Tabrizi• 300@KasraTabrizi
Posted
I was also having issues positioning the images in desktop mode, so you are not the only one lol. Especially with the small box and the pattern image.
But it looks good otherwise!
0 - Kasra Tabrizi• 300
@KasraTabrizi
Submitted
Hi guys, I wanted to know if my Javascript implementation is good or not. I'm happy to hear if there is a better way to write the logic.
Thanks in advance!
Kasra Tabrizi• 300@KasraTabrizi
Posted
Does anyone happen to know why my screenshot doesn't match with the assignment screenshot? I have a pixel-perfect design on my laptop screen, but it doesn't look that way on the screenshot. It seems to me that frontendmentors takes a screenshot with a certain viewport
0 - Muhamad Rizky• 140
@bodashideung
Submitted
Any feedback are welcome.
Kasra Tabrizi• 300@KasraTabrizi
Posted
I would adjust the spacing a little bit to make it pixel perfect, but other than that, it looks very good!
0 - 👾 Ekaterine Mitagvaria 👾• 7,640
@catherineisonline
Submitted
Hello, Frontend Mentor community! This is my solution to the Base Apparel coming soon page.
I appreciate all the feedback you left that helped me to improve this project. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.
You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.
Thank you
Kasra Tabrizi• 300@KasraTabrizi
Posted
Nice job! I would give a box-shadow to the button and make the input element have a white background color. Other then that, looks great!
0 - Kenn Bach• 140
@kennbach
Submitted
Hello Mentors,
Thank you for taking the time to review my project. Please feel free to make any comments and suggestions, as all feedback is welcome.
Cheers!
Kasra Tabrizi• 300@KasraTabrizi
Posted
Nice job!
0 - 👾 Ekaterine Mitagvaria 👾• 7,640
@catherineisonline
Submitted
Hello, Frontend Mentor community! This is my solution to the IP address tracker.
I have read all the feedback on this project and improved my code. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.
You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.
Thank you
Kasra Tabrizi• 300@KasraTabrizi
Posted
Nice job!
Only one issue: The map and info doesn't change when searching for a different IP address. It always shows the default one from Georgia.
0 - Kenn Bach• 140
@kennbach
Submitted
Hello Mentors,
Thank you for taking the time to review my project. Please feel free to make any comments and suggestions. All feedback is welcome.
Cheers!
Kasra Tabrizi• 300@KasraTabrizi
Posted
It looks pretty good! There is only a slight difference in the image. The original design has a blue-ish overlay on the image.
0 - Svetlana Jokic• 90
@Holllyyyy
Submitted
Hello everyone, your feedback will mean to me a lot. Thank you :3
Kasra Tabrizi• 300@KasraTabrizi
Posted
It looks pretty good! I would only look for adding a shadow-box and adding some font weight to the text.
Marked as helpful
0 - 👾 Ekaterine Mitagvaria 👾• 7,640
@catherineisonline
Submitted
Hello, Frontend Mentor community! This is my solution to the Testimonials grid section.
I have read all the feedback on this project and improved my code. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.
You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.
Thank you
Kasra Tabrizi• 300@KasraTabrizi
Posted
Very well done! I only see a slight difference in font weight but other than that I would say it is pixel perfect!
Marked as helpful
1 - Kenn Bach• 140
@kennbach
Submitted
Hello Mentors,
Thank you for taking the time to review my project. Please feel free to make any comments and suggestions, as all feedback is welcome.
Cheers!
Kasra Tabrizi• 300@KasraTabrizi
Posted
Hi Ken Bach,
It looks really good! If you also add some box shadow to this, it will look perfect!
Marked as helpful
1 - Prajwol Shrestha• 190
@Prajwol-Shrestha
Submitted
Any Feedback is really appreciated.
Kasra Tabrizi• 300@KasraTabrizi
Posted
Nice job!
Two minor things:
- I would use a lighter box shadow.
- The title of the box should have a bigger font size.
Other than that, keep up the good work!
Marked as helpful
1 - Byron• 2,180
@byronbyron
Submitted
Hello ladies and gentlemen! I've had a stab at doing this IP tracker with the map using SvelteKit. I'm a bit of a noob with SvelteKit at the moment, so I've probably bodged it quite a bit. At least the styling is on point, though! 😅
Kasra Tabrizi• 300@KasraTabrizi
Posted
In terms of design and responsiveness, everything looks good!
For the functional side, I would also look for adding a way to search for domain name because that is also mentioned in the input placeholder.
Also great job making this with Svelte!
0 - Kasra Tabrizi• 300
@KasraTabrizi
Submitted
Hey everyone!
At the moment, the API keys for the geolocation and leaflet map are visible in the repo. Anyone has an idea how to use environment variables with Vanilla JS? Is there a way without using NodeJS? How do you load the environment variables on GitHub pages?
Perhaps this isn't necessary in this case, but it is a good practise for when you make a serious project.
Thanks and open to other feedback as well!
Kasra Tabrizi• 300@KasraTabrizi
Posted
I also would like to mention that the block below the search bar where the additional info is displayed, is not visible when you visit the page because it will fade in when you do your first search (hence why you don't see it in the screenshot).
0
