All comments

• 

  Thomas Erdmenger• 270

  @thomaserdmenger

  Submitted about 1 year ago

  What I have learned:

  I learned Resolution Switching: A given Image in a mobile First Approach switches to another source on another resolution.

  My questions to the community:

  Is the semantic HTML I have used correct?

  There is still a DIV in my Code. What can I use instead of this DIV in the context of semantic HTML?

  I have used only Flexbox. Is Grid a better approach? And how should I have used it?

  I am very happy about any advice!

  Best regards Thomas

  

  Product Card Component with Flexbox

  2

  6

  0

  

  GIGACHAD• 230

  @Khalid-debugg

  Posted about 1 year ago

  Firstly, congrats on your stunning solution. The only advice that I would give is that you must have a <main> tag on any page you make, I heard a couple of geeks saying that for screen readers and accessibility reasons.

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  ahmedalaa109• 80

  @ahmedalaa109

  Submitted over 1 year ago

  Waiting for feedback :)

  

  Product preview card component

  1

  2

  0

  

  GIGACHAD• 230

  @Khalid-debugg

  Posted over 1 year ago

  This comment was deleted about 1 year ago

  1

  This comment has received 1 replyShow
• 

  Olha Zakharchevna• 50

  @zakharchevna

  Submitted almost 2 years ago

  Why there are different heights of flex items (img and content) between 550px screen-width-630px screen-width?

  

  Responsive preview product card using flex-box, grid

  #accessibility

  2

  6

  0

  

  GIGACHAD• 230

  @Khalid-debugg

  Posted almost 2 years ago

  Firstly, congrats for your solution you really did a great job. I recommend that you put the background color to the body element not to the products section, and also make the body as a flexbox. like: ''' body{ background-color: whatever; display: flex; flex-direction: column; justify-content: center; align-items: center height: 100vh; } '''

  Marked as helpful

  0

  This comment has received 3 repliesShow
• 

  Yoseif Alfiky• 90

  @Yoseif-Alfiky-1

  Submitted almost 2 years ago

  Tell me your opinion , help me to improve my skills.

  

  flex-box (Perfume)

  1

  4

  0

  

  GIGACHAD• 230

  @Khalid-debugg

  Posted almost 2 years ago

  It actually looks great you did a really good job!!! My advice is to stick to the style guide file (according to the font and color properties), and solve the HTML issues reported (like the title and the favicon). And if you get stuck somewhere -as all we have been through- after finishing your trial try to look up solutions on youtube so you can actually get better and try to learn from them not just to copy them.

  Marked as helpful

  0

  This comment has received 2 repliesShow