Skip to content
OverviewSolutions
11
Comments
10
Lackevil
@Lackevil

All comments

  • Ian Parker•200
    @i-prkr
    What are you most proud of, and what would you do differently next time?

    I proud to feel as though I am getting a handle on Sass and BEM. I still need to spend more time looking at the design and thinking how to structure the code to make it the most DRY.

    What challenges did you encounter, and how did you overcome them?

    I found it challenging working out how best to structure my .card component css, to make it as clean and as DRY as I could. I tried a couple of different ways using BEM, and decided to keep all css for both the signup and success card under the one class.

    What specific areas of your project would you like help with?

    I would really appreciate any feedback, but particularly would love to know if the BEM method has been implemented effectively. Particularly working between .card and .card-success classes as the success card had a slightly different layout.

    I would also grealt appreciate any improvements on my sass code, I am enjoying working with Sass/BEM and am keen to keep improving.

    Thanks for looking at my solution!

    Newsletter signup (Sass, BEM)

    #accessibility#bem#sass/scss
    1
    Lackevil•130
    @Lackevil

    Great!

  • P
    Dan Marius•1,275
    @danmlarsen
    What specific areas of your project would you like help with?

    I appreciate any helpful feedback

    Vanilla JS & Flexbox

    #bem
    1
    Lackevil•130
    @Lackevil

    Greate work!

  • Ian Parker•200
    @i-prkr
    What are you most proud of, and what would you do differently next time?

    I'm really happy with having spent the time to try to learn Sass properly, and implement it with the folder structure using partials. As well as this, to use Sass functions, maps and loops to be able to apply styling to the cards and change the grid based on media breakpoints. I also began to start using BEM which I plan to continue with.

    What challenges did you encounter, and how did you overcome them?

    I found it challenging understanding the best way to implement breakpoints in Sass, and it lead me to some great articles as linked in the readme that helped me understand a few Sass features.

    What specific areas of your project would you like help with?

    I would love to ask for feedback and help on two things in particular:

    1. My solution looks a lot bigger than the design in the screenshot. The style guide specifies a font size of 13px, but if I set this then the font does not appear as nicely on the design even though it is the correct size overall. So I kept it with the nicer font size, does that matter?

    2. Any feedback on my implementation of Sass and BEM would be awesome!!

    Thanks for looking at my solution!!

    Responsive Testimonials Grid using Sass

    #bem#node#parcel#sass/scss
    1
    Lackevil•130
    @Lackevil

    Greate work! I like your stack. But preview site doesn't load styles.

  • P
    Eli Silk•1,040
    @elisilk
    What are you most proud of, and what would you do differently next time?

    Thanks to the comments and looking at some other solutions, I was happy with my revised grid solution that takes advantage of the grid-auto-flow and the grid shorthand to position the cards correctly.

    What specific areas of your project would you like help with?

    If anyone knows how to get the top borders of each of the cards to have a straight edge rather than curved that would be helpful.

    Solution with flexbox and grid layout and CSS custom properties

    #bem
    2
    Lackevil•130
    @Lackevil

    You have greate vision!

  • Lackevil•130
    @Lackevil

    Good job! I like the hover animation on image. You should to create custom README, it gives others people to understand what you learned, what was your struggle and something else.

  • Lackevil•130
    @Lackevil

    Hello! Great job! I've seen your code and it's awesome. I suggest you to use BEM in your next projects.

  • P
    Eli Silk•1,040
    @elisilk
    What are you most proud of, and what would you do differently next time?

    This challenge was fairly straightforward.

    What challenges did you encounter, and how did you overcome them?
    • I'm never sure if I've matched the font correctly.
    • I was confused about how the profile changed from the mobile to desktop, and so may not have captured that fully.

    Social links profile with hover states for links

    #bem
    1
    Lackevil•130
    @Lackevil

    Greate work!

  • Lackevil•130
    @Lackevil

    Hello! Greate work! Respect for rems and good organized.

  • Lackevil•130
    @Lackevil

    Hello, nice work! I suggest you trim the markup and styles and use semantics tags! Good luck!

  • Lackevil•130
    @Lackevil

    Nice work! Btw, try writing image sizes exactly in the HTML tag. It's good for optimization.