Any Feedback will be appreciated.
Leccon1
@Leccon1All comments
- @ROKUROO7What specific areas of your project would you like help with?@Leccon1
greet job
- @AriarzgWhat are you most proud of, and what would you do differently next time?
It was the first project that I used Tailwind CSS, and I think I nailed it. it was very enjoyable to work with Tailwind CSS. Now I understand why everyone loves it.
What challenges did you encounter, and how did you overcome them?I thought this challenge gonna be a problem, but NO. I managed to do it all by myself in about 4-5 hours. Not very long time I think for the first time tailwind CSS user.
What specific areas of your project would you like help with?I would appreciate any suggestion about refactoring or improving the code! <3
@Leccon1good work!
- P@siddharthdb@Leccon1
Great job
- @nerdynischalWhat are you most proud of, and what would you do differently next time?
Managed to add the interactivity as intended on mobile and desktop versions, although the middle screen sizes might be a bit sub optimal for the time being. So, maybe some time to flesh out the middle screen sizes, especially for the tooltip component would be something to improve on.
What challenges did you encounter, and how did you overcome them?The most challenging part was getting the interactive part differently on mobile and desktop versions, but with more experimentations with the CSS, it eventually worked the way it was supposed to.
@Leccon1Hi, great job but I found a couple of flaws:
-
This is because share-container is a little uneven in relation to share-btn, it could be moved a little to the right.
-
The absence of BEM, its use makes the html code more correct and readable.
I would also recommend using SASS, it will greatly simplify the styling of the project.
-
- @lucassalles-gitWhat are you most proud of, and what would you do differently next time?
Aprendi um pouco mais de grid, gostei bastante.
I learned a little more about grid, I really liked it.
What challenges did you encounter, and how did you overcome them?Foi meio complicado aprender um pouco do grid, mas consegui.
It was a bit complicated to learn a bit about the grid, but I managed it.
@Leccon1good!
- @ReeperC3What are you most proud of, and what would you do differently next time?
I really like how I switched between grid and flexbox interchangeably to make the desktop version match as closely with the preview image.
What challenges did you encounter, and how did you overcome them?I struggled slightly to get the font sizing right, which was just trial and error.
What specific areas of your project would you like help with?Any advice on my general structuring or things like that. Thanks guys!
@Leccon1in the html code you used BEM a little incorrectly, for example, instead of the class name card-container, you could have done it like this: card__container, so you declare a new block. Or, instead of creating a separate class blue, etc. you could have done it with the card modifier, example: card--blue. But overall, the work is very good, you can be proud of yourself ;)
Marked as helpful - P@QuentinTengaGithub@Leccon1
Great job, but lacks similarity to the model
- @hussein430@Leccon1
Great work
- @andrushchenkoo@Leccon1
.
- @Bleudot@Leccon1
Hello Bleudot! Great job on completing the task!
I apologize if I'm wrong.
- I can offer you a few tips that you might find helpful. If you want to add space between elements inside a flexbox container, you can use the gap property. The problem with using justify-content: space-between is that it requires a fixed height, which is not recommended because it prevents the content from expanding. Here's an example of using gap to create a 30-pixel space between elements:
.button-1 { display: flex; gap: 10px; /* creates space between child elements */ }
- If you want to add hyperlinks to other websites or pages, using the <button> element would be incorrect, since in HTML, <button> is intended for creating interactive buttons on a webpage. It is used for actions like submitting forms, running scripts, toggling interface elements, and so on. Therefore, for links, you should use the <a> element — which in HTML is designed for creating hyperlinks — elements that allow users to navigate to a specified URL (URL) to another page, a section within the current page, or perform other actions. The problem with using <button> is that it cannot be used as a link to other pages or sites. You can read more about this here: click
I hope you find this helpful! First of all, your proposed solution is excellent! Happy coding!
- @BrianAugnoo@Leccon1
/:
- @BrianAugnoo@Leccon1
This work can be improved by removing attribution under the card, so the card will be centered, which is just what you need for similarity with the layout. I can also recommend the program “Pixso” - it's a free alternative to “Figma” that allows you to better analyze the layout, and not to do everything by eye ;)
- @jroblesclaudio@Leccon1
Не слишком точно, но все равно отличная работа!