Skip to content
OverviewSolutions
21
Comments
25

Malesela Kgobe

@M-KgobeSouth Africa585 points

I am trying to improve my html and css skills with the challenges.

I’m currently learning...

I am currently learning Javascript

Latest solutions

View more solutions

Latest comments

  • Malesela Kgobe•585
    @M-Kgobe

    Hi Nice work on this one.

    I have a suggestion to reducing your JS lines of code. since your dropdown elements have similar classname, instead of getting your elements one by one, you could assign them to one variable by using querySelectorAll/getElementsByClassNames, therefore instead of having mutliple eventlistener, you could use a ForEach function to iterate through classes you click on.

    Marked as helpful
  • Malesela Kgobe•585
    @M-Kgobe

    Hi Your website is not published properly, try moving the the html document to the root folder, and you might need to update your links thereafter.

  • Malesela Kgobe•585
    @M-Kgobe

    Hi... nice work on this

    I suggest you increase your .app's height to a 100%, because now the background-image just looks a bit ugly.

    and you might also wanna adjust the .hills-img afterwards.

    Marked as helpful
  • Malesela Kgobe•585
    @M-Kgobe

    Hi...

    In mobile(am currently on mobile) the card is not centered, it overflows out of the viewport. Perhaps changing the width: maybe to a % value will help a lot

    Marked as helpful
  • Malesela Kgobe•585
    @M-Kgobe

    Hi Your solutions looks pretty good.

    Your github repo does not work, you might have posted an incorrect link or something. you also seem to have a lot of issues in your report, check it out.

    Marked as helpful
  • Malesela Kgobe•585
    @M-Kgobe

    My suggest are that:

    1. Try setting a min-height:100vh to your body element, and make all contet to fit without overflowing.
    2. I would also suggest using landmarks in your HTML document, check-out your report for more info.
    3. Increase the max-width of the @media to about 900px(personally this is usually my first media query then followed maybe by 600px then 400px/450px/475px), you have to use those devTools.
    4. Explore a bit of transitions.

    other than that, the layout seems pretty good. and the slider works fine

    Marked as helpful
View more comments