Ryan Mahara

Latest comments

• 

  Ryan Mahara•135

  @MainlyColors

  Submitted almost 4 years ago

  

  Responsive site built with mostly HTML/CSS and JS only for email input

  2

  22
  

  Ryan Mahara•135

  @MainlyColors

  Posted almost 4 years ago

  Fixed the label and added some animations to it if anyone wants to check it out, tried getting the website perfect the screenshot stops being a few pixels off but after checking I matched the figma, idk why its still off?

  0
• 

  Matias Mass•280

  @MatiasMass

  Submitted about 4 years ago

  

  No one

  1

  10
  

  Ryan Mahara•135

  @MainlyColors

  Posted about 4 years ago

  your github pages is showing the readme instead of the index.html, I assume the reason is your files are inside a doc folder but you didn't link the github pages setup to that folder.

  The SVG images could be linked with an <img> tag instead of using the raw SVG code. like below:

  <img src="./images/icon-sedans.svg" width="64" height="40" alt=""/>
  

  In this example we use "./" in the beginning of the link to say current directory then the normal folder structure after that. This is called the relative path, its relative to the index.html file location.

  Also look into semantic HTML, the accessibility report is yelling at you because it expects to find a <main> tag which defines the main content on the page for people that use screen readers.

  Hope this helps, keep putting that work in😁

  0

  Marked as helpful