Skip to content
OverviewSolutions
1
Comments
1

Maja Korbøl

@Majzen11Oslo10 points

Photographer, makeup artist, learning to code.

Latest solutions

  • QR Code Component using CSS flexbox.

    Maja Korbøl•10
    Submitted 4 months ago

    I was unsure if I needed to add a <section> tag within my <main> for correct semantic html since this was all one section. I decided not to because I needed to use a <div> anyway, but should I have used a <section>?

    Am I missing any important parts of the semantic html?

    How should I have managed the sizing? Is there a better way than eyeballing it? The project does come with sizing, but I was unsure of how to use these, as they seemed to be the screen sizes and not the size of the elements.

    Is there a better way to center an element than the way I used? Would grid have been better or was flexbox a good option?

    1 comment

Latest comments

  • Maja Korbøl•10
    @Majzen11

    Hi!

    Your work looks great! I can tell you know a way of doing things that I haven't learned yet. It's interesting to see a different approach.

    I suppose the only constructive feedback I could give is that you could add line-height to your <p> element to make the text a little bit more spaced out and easier to read.

    But it looks very good! Well done!