Skip to content
OverviewSolutions
12
Comments
5

Manik Kapoor

@Manik2375Earth370 points

I am Just Learning ;)

Latest solutions

View more solutions

Latest comments

  • Manik Kapoor•370
    @Manik2375

    Hi there, sorry to say but you have too many accessibility and HTML issues.

    About bit accessibility, you don't have any hover states or any other way of telling if you have clicking/hovering the button or not. And images are also bit of low resolution :sweat_smile:

    But I really like how you extended the challenge :thumbsup:

    Marked as helpful
  • Manik Kapoor•370
    @Manik2375

    Hi @Ben nice work on animation, I really liked the hiding one, though talking about methodology, I see you are using BEM, but you aren't following it correctly :(

    According to it, element should not contain element, which in your case is .job__description which represents an element contains other elements.

    Nice work btw :thumbs_up:

  • Manik Kapoor•370
    @Manik2375

    Hi, to the point here are some things that I'd like to suggest:

    • The current product quantity can go below 0, which looks weird.
    • Take a look at html-accessibility issues.
    • The product page get connected with very bottom, I'd suggest to use some margins/padding
    • The backdrop of product images, when scrolling stays at top, perhaps use position: fixed for it.
    • Hover interaction of small thumbnail images, change cursor there.
    • They also don't have arrows to change image, which according to design you should have those.
    • Cart don't show how many items/or if items are selected or not.

    These are what I currently saw, good luck for your next project!

  • Manik Kapoor•370
    @Manik2375

    Any suggestions ^^?

  • Manik Kapoor•370
    @Manik2375

    About issues, well I have to take a11y course for it. And about buttons one, didn't wanted to use js + for section one, headings aren't the direct child so..

    Ik design isn't much same, in terms of elements size, that's because this challenge was done just for own practice, nothing special. :P