@Passenger89
Latest comments
- @ManuGil22
Hey there! Pretty cool solution! Have one thing to say as feedback:
- Always use heading tags in order! You should use <h1> first and if the font its too big u can always style it with css!
<h1 class="card__name">Victor Crest</h1>Everything else seems pretty good for me! Well done :D
- @hrishikdm@ManuGil22
Hey @hrishikdm pretty cool solution! Have some things to say as feedback:
- Wrap all body content in a <main> tag for accessibility purposes.
- Always use heading tags in order. Dont use <h2> or <h5> as a first tag, you can use a <h1> instead and change the text-style with css!
<h1>How did we do?</h1>Also for the text area were u have h5 and h2!
Marked as helpful - @Danny-Rodriguez@ManuGil22
Hey @Danny-Rodriguez pretty cool solution! Have only one thing to say as feedback:
- Always use heading tags in order. Dont use <h4> as a first tag, you can use a <h1> instead and change the text-style with css!
Marked as helpful - @AbhishekBh72@ManuGil22
Hey @AbhishekBh72
To position a element in the exact center of a page you can use this attributes on the body element:
- height: 100vh; //To make the height of the body 100 viewheight units
- display: flex; //To use flexbox
- justify-content: center; //To center elements horizontally
- align-items: center; //To make all items center in the page vertically
I hope I answered your question! Keep pushing and happy coding!
Marked as helpful - @victorsonet@ManuGil22
Hey @victorsonet !
Some feedback:
- Your media queries are not working properly. Maybe its better if you wrap the qr-section and content-section in one container and work with that container size. I would probably do a max-width: 350px for that container and u wont need to add queries. However u will have to change some of ur css in order to do that.
This is a link to my solution: Frontend Mentor solution
If you want u can take a look at it and ask me anything u need.
Keep pushing and happy coding!
Marked as helpful - @soodaayush@ManuGil22
Hey @DevBaddy ! Good work there! Your repo link its not working tho, cant check the code to give any feedback. However it seems all good. Try to add a <main> tag around the code for accessibilities purposes!
Well done and happy coding!
