Skip to content
OverviewSolutions
19
Comments
3
P

MarcoDV

@MarcoDV47Brasil280 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

View more solutions

Latest comments

  • P
    MarcoDV•280
    @MarcoDV47

    Hey, it's pretty good!

    Just a few tips to improve:

    • Use the pointer cursor when hovering the button and slightly change the appearance.
    • Add a little more margin on smaller screens so it don't touches the edges.

    Great job, keep going!

    Marked as helpful
  • P
    MarcoDV•280
    @MarcoDV47

    Hey!

    Here's what I noticed:

    HTML

    The div tags should have a closing tag, this is VERY important.

    GIT

    Careful when adding files to git. 3 unrelated projects were uploaded along with this. make sure to use the cd folder-name command to navigate to the project you want to update before using git add ..

    Besides that, this is a great solution!

    Hope it helps :)

  • P
    MarcoDV•280
    @MarcoDV47

    Hey, it looks nice! Some tips i can help you with:

    HTML

    • span heading: two heading tags would be better here, they give more meaning and accessibility :
    <span class="head-1"> Reliable,efficient delivery </span>
 <span class="head-2">Powered by technology  </span>

    CSS

    • header: instead of using flex to center text you could use text-align on the header tag.
    • <img> alt tags: as they're decorative you can leave the alt="" blank.

    Other than that it's a really great job! I liked your decision to go with flex. Maybe try with Grid some other time and compare to see what you feel more comfortable with.

    Marked as helpful