All comments

• 

  Eric Wisdom Agu• 20

  @Ericwiz

  Submitted about 2 years ago

  please check out my solution and suggest areas of improvement.

  

  css Grid, html, flexbox

  #accessibility#angular#backbone#bootstrap#express

  2

  5

  0

  

  P

  Marius• 190

  @MariusHor

  Posted about 2 years ago

  Great job so far! 🙂

  for the background you could add these lines: background-color: hsl(225, 100%, 94%) background-size: contain background-repeat: no-repeat.

  I would also suggest that you dont set fixed heights and widths on elements. Use padding to create space within an element and margins to create space between elements and not top left or position: relative / position: absolute. Google "spacing in CSS" for a better understanding.

  Keep going, you are getting there! 🙂

  0

  This comment has received 1 replyShow
• 

  Eric Wisdom Agu• 20

  @Ericwiz

  Submitted about 2 years ago

  Amazing Project, it was fun throughout the coding period, from start to finish. however, I found it difficult adding the horizontal line that separated the image section from the rest of the card...I would need help in adding and adjusting the line properly.

  please criticize my work and suggest areas of improvement!

  

  NFT preview card

  #accessibility#angular#express#jquery#backbone

  1

  5

  0

  

  P

  Marius• 190

  @MariusHor

  Posted about 2 years ago

  Hi,

  the horizontal line can be added by using the hr tag. You can then style it inside css using background-color: hsl(215, 32%, 27%); height: 1px; border: none;

  I would also add a padding to the card container so the horizontal line doesn`t go to the edges of the card.

  What I would also suggest that you keep learning how the box-model works, so that you will know where and when is best to apply the padding and margin properties. You can look up Kevin Powell on Youtube for easy to follow videos on this subject. :)

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  hafsa• 10

  @hafsabn

  Submitted about 2 years ago

  I really have a big problem in position the text in the same line with images that's why i am not sure in my code especially in the areas where there are a text and a picture in front of it . So if there are some resources or practices to learn more in this subject please let me know and thanks.

  

  nft_preview_card_component

  4

  7

  0

  

  P

  Marius• 190

  @MariusHor

  Posted about 2 years ago

  Hi,

  I would suggest that you start learning about Flexbox and Grid in order to gain some knowledge on how to position certain elements where you want them. You can check you Kevin Powell videos on this subject as they are beginner friendly and very easy to follow. I would also advise against using text-align: justify because it will make the spacing between words look off.

  Happy learning! 😉

  Marked as helpful

  1

  This comment has received 1 replyShow