Skip to content
OverviewSolutions
1
Comments
2

MarwanElZaher

@MarwanElZaher40 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

  • product-list-with-cart app demo using (react redux js css)

    #react#redux
    MarwanElZaher•40
    Submitted 10 months ago

    I need support in reviewing my code to ensure it aligns with clean code principles. I'm particularly interested in feedback on the readability, simplicity, and maintainability of my code. I would appreciate a detailed review to identify any areas where I could improve my coding practices, such as naming conventions, code structure, and the use of functions.

    1 comment

Latest comments

  • MarwanElZaher•40
    @MarwanElZaher

    Hi HMQui,

    First off, I want to commend you on the design of your webpage—it’s visually appealing and shows a lot of thought.

    However, I noticed a few UI/UX behaviors that could be improved, especially since you’re using plain JavaScript:

    1- When an item is added to the cart, it's crucial to save the selected item in the state. This ensures the counter for that item is displayed and a border appears around the product, signaling to the user that it’s been added to the cart.

    2- If an item is removed from the cart, the "Add to Cart" button should reappear, and the counter should disappear to reflect the removal. Paying attention to these details can significantly enhance the overall user experience. Keep up the good work, and I’m looking forward to seeing how you refine this project!

    Regarding the code, it efficiently handles basic cart operations like adding, removing, and updating items. It’s well-structured but could benefit from improvements in state management by encapsulating related data into objects. Caching frequently accessed DOM elements and using event delegation would enhance performance. Additionally, refactoring the updateCartAmount function into smaller, single-purpose functions would improve readability. Overall, the code is functional, with opportunities for optimization and better maintainability.

    Marwan El-Zaher, Mid-level Front-end developer, GIS PLUGINS CREATOR

  • Temesgen Adane•310
    @temesgen-982
    What are you most proud of, and what would you do differently next time?

    Layout is becoming easy. Using the Figma design helped a lot.

    What specific areas of your project would you like help with?

    Organizing the CSS file. It is an absolute mess.

    Blog Preview Card

    1
    MarwanElZaher•40
    @MarwanElZaher

    "Overall, the project looks great—it's responsive, and the layout is identical across different devices. One area for improvement could be the font weight; it might need a bit of enhancement to ensure better readability and consistency. Other than that, it's shaping up really well!" Marwan ElZaher, Front-end Developer

    Marked as helpful