P
@Matthieu83600
P
Melbita
@MelbitaAll comments
- P@Melbita
Nicely done!
- P@JF451What are you most proud of, and what would you do differently next time?
I am proud of how I used media queries to align things. I want to do differently how to position the top logo with ::before and ::after pseudo elements.
What challenges did you encounter, and how did you overcome them?I had difficulty aligning the items across different device sizes.
What specific areas of your project would you like help with?I would have help with the layout of the site.
P@MelbitaHi Justin,
I'm not able to see your project images, you can start checking if they're linked propperly where you hosted the page. You can also use media queries to adjust how some ui elements are displayed, this particular project display some of them differently according to the viewport size ex(mobile,tablet,desktop). I just finished the same project, check my profile if you would like to check for some ideas on how to tackle some of the challenges.
- @rounakkumarsinghP@Melbita
Unfortunately I was not able to see the code, however I would say based on the screenshot comparison: Check the white card background color, looks transparent, other than that, the card container could be vertically/horizontally centered.
- @taufiqz11P@Melbita
Looks good overall,
One suggestion could be to tweak the html to make it more semantic, using html tags such as main, header, section etc.
- @AnahiSUP@Melbita
Overall looks good. I liked how you used shorthands for border radius.
Personally I rather use classes instead of a bunch of #Ids. Regarding the images, you can directly use <picture> and srcset instead of displaying/hiding the images in your css.
Well done!.
- P@DonahuecWhat challenges did you encounter, and how did you overcome them?
Took awhile to figure out how to match the list styling to the design. First I tried to update the ::marker element, but ended up settling for styling a ::before element and using css counters
P@MelbitaYour solution looks super clean, Great use of css variables, and the mobile version looks identical.
Well done!
- @KyvenTWhat are you most proud of, and what would you do differently next time?
I'm proud that my first attempt at making something with HTML and CSS looks nice and clean.
What challenges did you encounter, and how did you overcome them?It took me some time to figure out which sizes to use in media queries depending on the screen size. I tried various sizes and used the ones I thought looked best.
What specific areas of your project would you like help with?I wasn't sure how to best incorporate responsive layout practices (and still not really sure if I chose the best way). I would like any tips on font-sizes and scaling layouts to fit various screen sizes.
P@MelbitaI've noticed the a tags don't have the href attribute, and some top padding is missed on profile picture.
Other than that, looks good overall.
- @FroghangoutP@Melbita
I was not able to see the code since it gives me 404. However there are some minimal visual aspects that can be improved. For instance the vertical center alignment, this can be achieved using flexbox. Lastly you can improve the card's shadow tweaking the values you already have.
Well done!
- @kyasharkP@Melbita
Looks good
