Skip to content
OverviewSolutions
59
Comments
15

MichalTrubini

@MichalTrubiniSlovakia1,220 points

Frontend web developer. Tech stack: jQuery/vanilla js, React.js, Next.js, Vue.js, Mongo, Typescript

Latest solutions

View more solutions

Latest comments

  • MichalTrubini•1,220
    @MichalTrubini

    Hi everyone,

    Could someone please advise me regarding error "Attribute loading not allowed on element img at this point."?

    Is this because the validator is not yet configured to include lazy loading as proper syntax for img tag?

    Cheers

  • MichalTrubini•1,220
    @MichalTrubini

    Hi Paula,

    When it comes to functionality, there is a small bug: it is possible to input multiple decimal points.

    I like the transition effect between switching themes. I should include one myself. :-)

    Michal

  • MichalTrubini•1,220
    @MichalTrubini

    Hello there,

    Any ideas why the accessibility report says there is an error "Form elements must have labels"? I actually included a label for the input (set it to hidden though).

    Thanks

  • MichalTrubini•1,220
    @MichalTrubini

    Thank you Sachin for the feedback. This has been fixed. I will re-generate the screenshot once it is possible because at the moment I am getting message about internal server error when attempting to re-generate.

  • MichalTrubini•1,220
    @MichalTrubini

    Hello there,

    Thanks for the feedback. I don't know what's wrong but when I click on "Preview site", the layout looks the way it should (as per the design figma file). However, the screenshot of the site (generated above these comments) shows the hero image on the left with "Humanizing your insurance" missing. Because the layout is correct when you go to the actual site, right: 12% should not be necessary. Or maybe I misunderstood you?

    What I forgot to mention when writing my original post is that the gap between hero image and the section that follows is visible on mobile devices.

    Michal

  • MichalTrubini•1,220
    @MichalTrubini

    Hi Rohit,

    According to the reporting tool, there are some accessibility and HTML issues. Not sure if you know, but prior to submitting the solution you can check for HTML issues using an HTML validator:

    https://validator.w3.org/

    Furthermore, I noticed that your input email field allows submitting when nothing was entered by the user. You can fix this by specifying "required" e.g.

    <input type="email" id ="email" required>

    As per design specs, there should be also an error message displayed on error. This can be added using javascript (I don't think pure CSS can do that job even though the author of the challenge claims only HTML & CSS should be used?).

    Regards,

    Michal

    Marked as helpful
View more comments