
Moisés Alfaro
@MoisesAlfar0oAll comments
- @realMoyosore@MoisesAlfar0o
Hey, your solution looks good, but I noticed that if I enter an invalid date, it still performs the calculation—whether the date is in the past or future
- @aksoyalpiWhat are you most proud of, and what would you do differently next time?
- working performant with little javascript code
- using data attributes to be more efficient
- no challenge but redundant code, because I did not use a framework to implement components
Is it a good solution or is there an easier way to solve this challenge (without frameworks)?
@MoisesAlfar0oHey, your solution looks good, but it doesn't work when I click on any of the timeframes. I checked the HTML and everything seems in place, but it looks like the issue might be with this line: fetch("/data.json").
This tries to load the file from the root of the domain, which won’t work if your data.json is in the same folder as your index.html. Try changing it to: fetch("./data.json").
Marked as helpful - @Abu-FaridatWhat are you most proud of, and what would you do differently next time?
Trying it even though it was hard
What challenges did you encounter, and how did you overcome them?Everything, I can't do the hide and show yet but I will learn it
What specific areas of your project would you like help with?How to do the hide and show
@MoisesAlfar0oHey, you can use the <summary> tag. I haven't done this challenge, but I can tell that it might work.
- @S4V10NWhat are you most proud of, and what would you do differently next time?
the fact that i built it correctly
What challenges did you encounter, and how did you overcome them?none i couldn't overcome
What specific areas of your project would you like help with?just general guidelines like BEM and CSS structure
@MoisesAlfar0oI'm not an expert or anything, but just a recommendation: instead of using a <div> as a button, you can use a <button> tag. Also, consider using an <a> tag instead of a <p> in the footer. :)
Marked as helpful - @Weblife007What are you most proud of, and what would you do differently next time?
I was able to complete the project Making enough research before engaging a problem
What challenges did you encounter, and how did you overcome them?Positioning
What specific areas of your project would you like help with?Everything Please
@MoisesAlfar0oGood! But consider using tags like buttons and a, which are built into HTML :) Also, use :root in CSS to define global styles or variables for your project.
Marked as helpful - @kmrzakir@MoisesAlfar0o
It's good but consider using a better box-shadow.
- @Mdhenderson14What are you most proud of, and what would you do differently next time?
I am most proud of learning and completing the project with CUBE CSS. Although it was tricky to understand at first, it makes a ton of sense and simplified how I organize my styling process.
What challenges did you encounter, and how did you overcome them?My biggest challenge was getting the correct layout for desktop widths. I was overcomplicating the entire thing. I started the layout all over simplified the layout of the card container.
@MoisesAlfar0oYou did well; I have nothing to say except about the shadow. It's just a design matter, nothing more:box-shadow: rgba(0, 0, 0, 0.35) 0px 5px 15px;
- P@LamprosVasilakosWhat are you most proud of, and what would you do differently next time?
Im proud of managing to make the design responsive
What challenges did you encounter, and how did you overcome them?My problem was on how to make the image of the project responsive. I managed to resolve the issue by implementing the image with the css background image property and changing with media queries for the small and large devices
@MoisesAlfar0oWow, I should learn from you!
- @Promerser@MoisesAlfar0o
It's fine, but you should avoid using too many divs.
- P@fringe4lifeWhat are you most proud of, and what would you do differently next time?
I am most proud of how simple the media queries are as it is quite possible from experience to have over complicated media queries!
What challenges did you encounter, and how did you overcome them?I wondered about what tag to make the Location Information, i.e. the London, United Kingdom. Initially I had chosen to make this an <h4> but I chose to make it a <p> as ultimately I decided a <p> was more suited.
I also accidentally set padding on the left and the right of the <li> tags causing a bit of head scratching as to why they were wrapping words.
What specific areas of your project would you like help with?I am curious as to whether you think using CSS layers in a card of this size is worth it as I wondered during implementation whether this was necessary or a needless over complication. However I have seen in Code Pen examples that people often use layers so maybe it isn't.
Also Would you have made the location information a heading tag or a p tag?
Thank you in advance.
@MoisesAlfar0ogood job!!
- @Westmatthew1What are you most proud of, and what would you do differently next time?
I learnt to be dedicated and consistent with learning daily
What challenges did you encounter, and how did you overcome them?I experienced a little stress, so i took a break and came back to it.
What specific areas of your project would you like help with?I need help with responsiveness and how to make my code more readable.
@MoisesAlfar0onothing to say
- @shannontimWhat are you most proud of, and what would you do differently next time?
This is my first time completing a challenge like this so I am proud that I completed it all the way!
What challenges did you encounter, and how did you overcome them?as far as challenges I didn't have any
@MoisesAlfar0onothing to say :)