All comments

• 

  Andre Franco• 70

  @AFranco-dev

  Submitted almost 2 years ago

  Should I try to do this with bootstrap? Did I do a bad practice?

  

  FIRST CHALLENGE QR code with pure CSS using flexbox

  1

  3

  0

  

  Michael East• 40

  @MrEasty94

  Posted almost 2 years ago

  Hey Andre, great job.... here's some feedback...

  1. I think you could use a <main> tag to wrap the card, I think this would be semantically correct.
  2. I think the 'attribution' section could be in a <footer> tag, again I think this would be semantically correct.
  3. For this, and future challenges, I would recommend setting your box-sizing to border-box. This makes calculating widths, heights, paddings, etc... a lot easier moving forward. One common way to do this is in your CSS, doing the following:

  *, *::after, *::before { box-sizing: border-box; }

  This sets all elements, including the after and before psuedo elements to the border-box model.

  Great effort and keep going! :)

  Marked as helpful

  1

  This comment has received 1 replyShow