Skip to content
  • Unlock Pro
  • Log in with GitHub
Profile
OverviewSolutions
9
Comments
1
Noa
@NoaSalgado

All comments

  • Ahmed Dosouky•20
    @Adosouky
    Submitted over 2 years ago

    QR-code-component

    2
    Noa•130
    @NoaSalgado
    Posted over 2 years ago

    Hi!!

    • The best way, in my opinion, to center .big_container would be to apply to the body a minimum height of 100vh (100% of the viewport height) and use css grid like this:
    body{
       min-height: 100vh;
       display: grid;
       place-content: center;
    }
    
    • The margins you apply in .big_container are not necessary. You can also apply flexbox to the body as you have done in .container.

    • Other recommendations would be to include the styles in a separate file. You should also use a <main> tag instead of <div> in the .big__container element to indicate that the content is the main content.

    • You should also include and <h1> heading

    I hope this helps. If you have any questions let me know

    Nice work!!!

    Marked as helpful
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub