@NitiemaAllassane21
Latest solutions
Faq accordion
#accessibility#pure-cssSubmitted 6 days agoi think there can still be improvements to be made, recommendations/feedback are more than welcome!
Tip calculator app
Submitted 20 days agoI'm not sure whether there are problems since its working fine, but feedbacks are much appreciated!
newsletter sign up with success message main(no api's used)
Submitted about 1 month agonone, for now since it works properly
Article preview component
Submitted about 1 month agomy design is not as accurate actually so i need some feedback to maybe fix that later
Latest comments
- @PastaSus
damn, didn't know you can do this with only html,css pretty cool to know! but anyways heres some things i think you should fix: Avoid Using <hr> Excessively or for Layout:
-
<hr>is for thematic breaks in content, not layout separation. Styling with borders or spacing is better.-Missing alt Text for Icons in Summary:
-The comment suggests adding icons (+ and –) but doesn’t specify their alt text. If used, they should have appropriate alt text (like "Expand answer" / "Collapse answer") or aria-hidden="true" if redundant.
-BEM Naming Not Consistently Applied:
Some classes (like first__detail) are not BEM. Use faq__detail faq__detail--first instead.Marked as helpful - P@JeronimoCardu@PastaSus
Good job
- P@Capt-Rong@PastaSus
Good job on finishing the challenge, i think the code could be refactored into something better.
- @AndresOreVelWhat are you most proud of, and what would you do differently next time?
Mobile design is the best. Next time I might make a different design for the tablet.
What challenges did you encounter, and how did you overcome them?At first, I didn't know how to do the desktop layout because there were some aspects of the grid I didn't understand, especially for the profile card.
What specific areas of your project would you like help with?In the tablet design, the cards shrink or stretch, any help to prevent this from happening is welcome.
@PastaSusyou need to use the proper tags here it since the readability of the code is kinda bad. Instead of using divs only try to use the proper markup to make the code more readable and accessible. Other than that good job on finishing the challenge
- @shrikanth-dev@PastaSus
bg color should be the lighter one, and darker color for the text.
you dont really have to use inline svg tag here just use the
<img src="svg.svg">tag its much cleaner and more performant.the error message should be at the end also
space-betweenhere would be a good solution to that problem :)The semantics can also be better by adding a
<section>tag and<main>tag - @Stanex96@PastaSus
theres a lot of things that are wrong here(eg. html semantics, how you did your article preview component from mobile to desktop, bg color for links on mobile should be showing as grey) i think you should go through the learning paths here in frontendmentor to really help you progress better
