Skip to content
OverviewSolutions
10
Comments
5

Paul THEUREAU

@Paul21777France120 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

View more solutions

Latest comments

  • Paul THEUREAU•120
    @Paul21777

    Hi !

    To answer your question I think that It depends on which screen size you think your website will be use the most.

    For example, if I wanted to create a Google Map like, I will surely design and build it mobile-first, because today the main purpose of these kind of applications is to be used outside in a mobility way.

    But if I wanted to build a Photoshop like website, I will surely build it desktop-only, because most of the user will use it on desktop.

    That's only my opinion :D

    And BTW your website is almost perfect congratulations !

    Marked as helpful
  • Paul THEUREAU•120
    @Paul21777

    Hi !

    I have completed this challenge a few days ago and I had problems too implementing this purple color before the img. I think your solution is pretty clear ! I search on the web too and I could not figure out a best practice for this unfortunately.

    Personnaly, I used the filter property in order to play with opacity and then I tried to find the right amount of saturation to get a good look since getting 100% the same color than the design was impossible for me.

    Hope that helps and maybe someone here could give us the best pratice (if there is one...)

    Keep the good work !

  • Paul THEUREAU•120
    @Paul21777

    Hi !

    Saw that your style.css is not properly link to your index.html. In order to fix this, you can delete the / character in the href attribute of your link mark (line 8, index.html on GitHub) since your style.css and your index.html are on the root of your repo.

    Hope that helps and keep the good work !

  • Paul THEUREAU•120
    @Paul21777

    Hi !

    Congratulations for this ! Your design looks really great ! To improve it, I suggest you to look at the accessibility issues FrontEndMentor gives you :

    First accessibility issue :

    You should have at least one landmark of "Content sectioning". Check the MDN documentation for more info : https://developer.mozilla.org/en-US/docs/Web/HTML/Element#content_sectioning

    In order to fix it, you can replace your <div id="container"> by a <main> element. You should only use <div> when their is no semantic options available for his purpose.

    Second accessibility issue :

    Your page should at least have one <h1> for the search engine optimization (SEO). I suggest you too replace your <h2> by a <h1>.

    Finally, you can try to stick as far as possible the layout given by frontendmentor (padding, font-size, width and height, text color...).

    Hope that helps, keep the good work !

  • Paul THEUREAU•120
    @Paul21777

    Hi !

    We can't see your work, It seems that your files has been directly commit inside the dvelopment folder.

    In order to solve this, you can move all the files inside your "interactive_rating_component" to the root of your repo and search on the settings of your repo to create a GitHub Page from the root of your repo.

    Hope that helps !

    Marked as helpful