Pénélope Martin

Latest comments

• 

  jay•50

  @Ragnarok344

  Submitted about 1 year ago

  What are you most proud of, and what would you do differently next time?

  I'm proud of using flex and flex direction column and row correctly and aligning all my stuff center.

  What challenges did you encounter, and how did you overcome them?

  Figuring out spacing of things and keeping it center without making it go to a certain side.

  What specific areas of your project would you like help with?

  Did i use flex direction and flex box container correctly?

  

  Social Links Profile

  1

  30
  

  Pénélope Martin•40

  @Pennymrtn

  Posted about 1 year ago

  Hello

  First of all, concerning your code, I am rather new too to Flexbox but I think you used it correctly and your code is organized and easy to understand so congrats on that! You have done a great job!

  However I have spotted a few redundance and "mistake" in your files :

  • You have image and . image img : they can be put together in img{ } you don't need to create a class for that. Be careful with the use of <div> as it makes it difficult for screen readers to navigate your content. If you don't need it don't use it!
  • In your html you introduce the class name but you never use it ! Same thing for the class named link. Introducing too many classes can make your code a bit harder to read.
  • In your html, there is no need to create different classes for each link because you give them the same aspect in your css.

  Otherwise you have a very nice code! And I thank you for introducing to me the fabulous existence of the vh unit. You have solved one of my problems with my code ! <3

  PS: That is going a bit far put it would be nice if the links you click on changed color. You can do that by using :focus. It gives a visual cue that yes this element is clickable and you clicked it (when website are a bit slow it is nice)

  0