@yasir-abas
YassineBen
@ROJOmaxAll comments
- @ROJOmax
Could've used form element in html. Check my code for the inputs sytling and the dynamic changes of the image container.
- @YounesAmazzalOriginal@ROJOmax
Great job my friend, ur website looks neat, there's some stuff u need to fix, but overall you've done a great job.
-I think it would've been better if you used unordered list in the numbered paragraphs, styling them is easier, specially the background color.
Marked as helpful - @TheMozzarellaCat@ROJOmax
Good Job.
- @ramram14What specific areas of your project would you like help with?
I would love to have any feedback on my code.
@ROJOmaxImpressed actually, neat and clean code, good job.
- @TheDrem94What are you most proud of, and what would you do differently next time?
Grid is now more comfortable for me. This challenge force me to use and understand it. It's very tricky sometimes. Especially using a grid-are, you have to thing more about positioning:)
What challenges did you encounter, and how did you overcome them?The biggest issue i got with this project is sizing and positioning.
What specific areas of your project would you like help with?I cannot understand why on first card name and title position self just in place, but in the other cards it doesn't work. Next thing is sizing cards in desktop layout. I cannot figure out how to make column to be 100% filled, maybe some of you have any solutions :)
@ROJOmaxadd display grid to container, add gap. add 4 columns(grid-template-columns: repeat(4, 1fr);) check my code.
Marked as helpful - P@Y39WebDeveloper@ROJOmax
Good job with the responsiveness. Need to work on top and bottom padding, there should be space.
- @thecodefanWhat are you most proud of, and what would you do differently next time?
My positioning was excellent. But i feel like i can use better ways to position items on different device sizes, i heard clamp() is very useful in this regard.
What challenges did you encounter, and how did you overcome them?My biggest challenge was going with a mobile workflow first, this was new for me.
What specific areas of your project would you like help with?A more efficient and easy way to design a site around different device sizes.
@ROJOmaxYou need to work on these: Line-height. Border-raduis. Add to cart button. Picture width. Original price color and placement. Font Colors. Responsivness.
- P@underhrWhat are you most proud of, and what would you do differently next time?
I'm most proud of the responsiveness, as this is my first time doing it in a very long time. I look forward to using it in my future projects.
What challenges did you encounter, and how did you overcome them?My biggest issue was learning how to add media queries & what exactly they did, but a few good google searches helped me out.
What specific areas of your project would you like help with?I was able to get the hover effect to fade in when hovering, but not to fade out. It worked on my last project so I'm not sure how to get that working. Not the biggest deal, but if you know how to fix it let me know!
@ROJOmaxyour code demonstrates a solid understanding of HTML and CSS principles, as well as attention to detail in design and responsiveness. Great job!
- @PY-Chua@ROJOmax
Your HTML code is clean, well-structured, and follows best practices. CSS is well-structured, and the styles are clear and consistent.
- @kira7777@ROJOmax
The link to the code isn't working, thus I can't review his code. Through previewing his website, he didn't respect desing requirements(father container padding and margin and he used a different font)
