Skip to content
OverviewSolutions
5
Comments
17

Giovanni Ruberto

@Rabberpoli260 points

Hi everyone! I’m an electronic engineering (bachelor degree) but I’m really into programming. I work as a software engineer and I’m always looking for new technologies and new things to learn.

I’m currently learning...

Develop better solutions

Latest solutions

Latest comments

  • Giovanni Ruberto•260
    @Rabberpoli

    Hi, Well done for doing this challenge! The final result is great!

    Back at your questions:

    • Using em or rem would be better than using just px. That's because px will be the same size for every screen resolution; this could be a problem in term of accessibility and responsiveness. So: yes, best practice suggests em or rem. You can read more here
    • Talking about commenting code: I usually comment code that it would be hard to understand if I read it after long long time. I would avoid to comment every single line and usually is best practice to write code that explains itself without the need of commenting every line.

    Hoping to be helpful, keep going and happy coding!

    Marked as helpful
  • Giovanni Ruberto•260
    @Rabberpoli

    Hi! Congratulations for completing this challenge! I think there was some error uploading your solution on github. That's because your project doesn't show your graphic solution. Maybe you're pointing to the wrong file or it is not where you're pointing to!

    That said, keep going and happy coding!

    Marked as helpful
  • Giovanni Ruberto•260
    @Rabberpoli

    Hi! Congratulations for completing this challenge! I think there was some error uploading your solution on github. That's because your project still has the same template frontend mentor provided when you enrolled in this challenge. Maybe you developed on another branch but you're pointing on master branch.

  • Giovanni Ruberto•260
    @Rabberpoli

    Hi! Well done completing this challenge! As you said, you used only margin and padding properties. This lets you achieve a pretty good result but it doesn’t guarantee a responsive behavior. A powerful property that can ease your job in term of responsiveness is flexbox (you can give a look at the documentation here). This property along with justify-content and align-items let you center automatically your DOM object without struggling with margins and paddings.

    Hope to be helpful, keep going and happy coding!

  • Giovanni Ruberto•260
    @Rabberpoli

    Hi! Congrats on completing your challenge! Graphically speaking it’s pretty good, you did a great job! The corresponding GitHub code is not available at the moment, so I cannot give you further informations.

    That said, keep going and happy coding!

  • Giovanni Ruberto•260
    @Rabberpoli

    Hi! Congrats on completing this challenge! You did a really good job! Back to your question, it is possible to render your results dinamically using JS. I try to explain one of the multiple solutions you can develop:

    const scores = [ ]; // here you can put your score objects

scores.foreach(score => {
   const categoryId = score.category + ‘-score’; // Here I’m creating the Id of the HTML element I have to modify

   const categoryHtmlElement = document.getElementById(categoryId);
   categoryHtmlElement.innerText = score.score;
});

    This should give the desired output.

    Let me know if it can be useful! Keep going and happy coding!

    Marked as helpful
View more comments