All comments

• 

  David de Oliveira Silva• 20

  @devdavidos

  Submitted over 2 years ago

  I would like to know, what are the good practices in html and css, and possible errors.

  

  A simple Card using HTML and CSS | Responsive

  1

  1

  0

  

  Randy Brilliant• 115

  @RandyBrilliant

  Posted over 2 years ago

  Here's a list of things that I can recommend you do it.

  1. For the height, you can use min-height: fit-content so there will be no wasted height in the design.
  2. For unit measurement, if possible you can try using the em rather than px which I think is much easier than defining custom pixel for each measurement.
  3. In the mobile view, you can use max-width: 80vw which can let the card's width overflow the screen viewport.
  4. As for the heading, I think it's better to start with h1 and so on, and you can style it using CSS to fit the design requirement.
  5. As for the button, it's better to just use <button> tag rather than input since you are not wrapping it inside a <form> tag.
  6. For the background, you can fit the color as well as the background which you can find here for references. Other than that, I think you are good to go, keep up the good work! 💪💪

  0