Detorlar Mubarak• 230
@Pious-coder
Submitted
Yassine Ghezal
@Ryusuke66
All comments
- Yassine Ghezal• 870
@Ryusuke66
Posted
Congrats on finishing the challenge your solution looks great, one thing i found is when i reload the website the advice changes twice sometimes, what causes that is this code in your Javascript file:
window.onload = () => { getAdvice(); }it's not needed since the API changes the advice every 2 seconds, so you can remove it and it will fix the issue. Good luck and happy coding!
Marked as helpful
0 - Hamid997• 400
@Hamid997
Submitted
first version without cleaning - Open for feedbacks
Yassine Ghezal• 870@Ryusuke66
Posted
Hi Hamid, your solution looks great, but there's a little issue, when the screen width is between 741px and 809px the page overflows sideways, to fix that you can change
.navLinkpadding topadding: 15px;instead ofpadding: 15px 30px, Happy coding!Marked as helpful
0 - Marvelous Martins-Abel• 10
@marvcoolguy
Submitted
give me feedback on my code
Yassine Ghezal• 870@Ryusuke66
Posted
- the background isn't the same as the design.
- using header image as a background is better than putting it as an element.
- the font family for the design is "Red Hat Display".
Marked as helpful
1 - Nembot Jules• 30
@NembotJules
Submitted
My third Challenge! I am open to all critics and reajustment. I also hope it can help someone out there Follow me on instagram if you like Science, Coding, self-development https://www.instagram.com/maxthephysicist/
Yassine Ghezal• 870@Ryusuke66
Posted
- Looks good, the issue is that from 500px to 900px the design is overflowing, you have to scroll sideways to see the rest.
Marked as helpful
0 - GastonGAlvarez• 10
@GastonGAlvarez
Submitted
I am starting in web development, any feedback or recommendation is welcome. Thanks in advance!
Yassine Ghezal• 870@Ryusuke66
Posted
- Good work, you should add
background-size: containand change thebackground-repeatproperty tono-repeatin the body element.
Marked as helpful
1 - Good work, you should add
