Skip to content
OverviewSolutions
24
Comments
13

Saif Narpali

@SaifN97Mumbai590 points

Friendly neighborhood tech guy

I’m currently learning...

Responsive layouts, SASS, Grid, React

Latest solutions

View more solutions

Latest comments

  • Saif Narpali•590
    @SaifN97

    Great work on this one!👏👏

    I'll suggest try using em units for margin / padding.

    When you use em units the spacing adjusts automatically depending on the font-size of the element as we shrink things down for mobile view.

    Have fun coding :)

  • Saif Narpali•590
    @SaifN97

    Hey Indarta, Good work on this one, Looks impressive as a first project!

    I see you're using div to wrap everything which is not ideal..

    I'll suggest look more into using correct HTML elements

    Have fun coding! :)

  • Saif Narpali•590
    @SaifN97

    Hey Humaira, great work on this one!

    I see you're mixing up css units and I remember struggling on that too.

    I want to share a general rule of thumb that made it easier for me 👇..

    • % for width and height
    • rem for setting font-size
    • em for margin and padding

    Have fun coding :)

    Marked as helpful
  • Saif Narpali•590
    @SaifN97

    Hey Carlos great job on this one!

    I struggled on changing svgs color on hover too.. This pen helped me👇 Css filter

    Marked as helpful
  • Saif Narpali•590
    @SaifN97

    Hey Mohamed Mahir great job on this one!

    The card content is flowing out while going small. I'll suggest avoid setting a fixed height to your cards and use padding whenever you need more background space.

    Have fun coding :)

    Marked as helpful
  • Saif Narpali•590
    @SaifN97

    Good job on the challenge 👏👏

    I am a big fan of sass too. They recently made a public notice on the deprecation of the @import rule, they are encouraging developers to use @use instead of @import.

    PS: with the @use rule, your CSS partials will be namespaced.

    Also I'll suggest looking more into the combo of using rem , em and % units instead of using px as it helps alot with the responsiveness.

    Lastly try to avoid setting fixed heights and use paddings and margins instead.

    Have fun coding! :)

    Marked as helpful
View more comments