Skip to content
  • Unlock Pro
  • Log in with GitHub
Profile
OverviewSolutions
14
Comments
2
Samyr Oliveira Ribeiro
@SamyrOR

All comments

  • Dominique•40
    @domiattaway
    Submitted over 4 years ago

    Four Card feature HTML-CSS

    2
    Samyr Oliveira Ribeiro•215
    @SamyrOR
    Posted over 4 years ago

    Hi Dominique!

    Looking into your repository, i din't find the img files, thats why the files don't show on the live site, and the style on repository maybe its not complet?

    I've cloned the repository and look like the same.

    Obs: vercel push from your git!

  • Lucas Laino•70
    @l-laino
    Submitted over 4 years ago

    Profile Card (HTLM, CSS)

    3
    Samyr Oliveira Ribeiro•215
    @SamyrOR
    Posted over 4 years ago

    Hello @l-laino, its look good at all, but somethings a think can be better, for best pratices you could put all colors that you will use, on variables of css, putting this on :root {}, this help in the maintence of the code (possible to put common sizes too and other things), matching all colors with the recived style guide , and for the bottom status under the numbers, you could space it with "letter-spacing" property.

    At the mobile, i would add more margin on top to center the card, and match the font-sizes to better view with media queries.

    The Mobile First aprochion, is a thing that i'm learning and loving it, you can code the entire site to mobile, and then with media queries just scale, this is much more easier, confortable than just try to make it fit on mobile, you could give a try, and look for mobile first.

    I expect that i have helped in something.

Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub