Андрій Рогов• 1,155
@Andrii-Rohov
Submitted
Hello, i am a newbie to JS. I find a way to write script and (it's bad). Anyway, if you have any feedback about my solution please leave a comment.
SathishVM
@SathishVM
All comments
- SathishVM• 280
@SathishVM
Posted
There is a simple solution that can be used to validate the email field using regex in javascript, Well regex is also known as a regular expression that validates the string by the pattern we provide. Writing a regex pattern is tough though you can google around it and use the available solutions on it.
https://stackoverflow.com/questions/46155/how-to-validate-an-email-address-in-javascript
You can learn from this resource.
0 - Michelle• 125
@myc15
Submitted
Since I added the border-radius separately, I was wondering if there is a way to add them all at once to the container?
Any feedback would be greatly appreciated. Thank you! :)
SathishVM• 280@SathishVM
Posted
Hello Michelle,
You have done a nice solution tho this challenge and simple as the structure in the code.
So instead of using border-radius separately you can use a container and in it, you can use padding to the div and it overflows the container so it will not visible and here you can use overflow: hidden so the overflow will not be shown and border-radius will visible and that's the hack I used.
I hope you got my point. :) Happy coding
1 - Rowland• 185
@Rowkibet
Submitted
Hello, I have encountered a problem when trying to make the page responsive. I wanted to kindly ask should I change the HTML markup I used or is it possible to get the layout for the mobile devices with the same markup I used?
I saw that getting the logo, text and input field would be ideal in getting the mobile layout but when I made the items separate it proved hard to get a desktop design close to the one provided in the challenge.
Any other feedback on my solution would be very much appreciated.
Thanks!
SathishVM• 280@SathishVM
Posted
Hello Rowland,
Yeah, rfilenko is right. use some media queries and don't use selectors and in the form input using flexbox will be more head pain when it comes to specifically for this solution and try reducing font-size by 1 or 2 px when it gets to mobile screen.
If you get problems again feel free to view my solution
https://github.com/sathishvm/Frontend-Mentor-Challenges/tree/master/base-apparel-coming-soon
1 - Joshua San Jose• 40
@forimbajosh21
Submitted
I would like to ask for feedback or enhancement I could make. Thank you
SathishVM• 280@SathishVM
Posted
Hello Joshua San Jose,
I tried to view the source code to view the solution of the challenge but the link is not found.
0 - Paz Spera• 170
@pazspera
Submitted
Hello, I'd love to hear your thoughts on the structure of my code, if it's clear and easy to read. Any feedback on the media queries used would be helpful as well. Thank you!
SathishVM• 280@SathishVM
Posted
Hello Paz Spera,
I really loved that you used grid system for the alignment and it's really simple solution than I solved ^_^.
Yes, your html structure such as naming the classes and id's are really simple and to read.
I found one thing you can improve that is at the min-width from 700 to 900 you can show the features as two card in a row and it will make the view as simple instead viewing one card line by line.
1 - Jasmine J• 30
@jjames93
Submitted
I found myself really struggling with the Icon section.
It was like there were a million different ways to get the item to "look" like the final product, but it conflicted with previous lines I had written - It was satisfying when I found a method I was pleased with.
Have you ever "coded" yourself "into a corner"? What are your strategies for righting yourself once you find yourself at a dead-end?
SathishVM• 280@SathishVM
Posted
Hello Jasmine J,
You have done a nice solution to this challenge.You asked what strategies for righting yourself code at the dead-end. Well I make a block level element and inside it I use another block or inline element according to it and I use margin-left as auto on it and it push the element to the corner.
So,this my strategy to code in the corner.I hope this will help you :)
Happy Coding!
0 - Adler G Luders• 1,580
@adluders
Submitted
No specific question but please feel free to leave any comments or feedback on how I could've improved the code or the design.
SathishVM• 280@SathishVM
Posted
Hello adluders,
Yeah you did a nice solution.I found only one thing that you can improve too. That is on service and article section paragraph line-height.
By increasing the line-height it will not hard to read. So,That's my only one feedback. :)
1
