All comments

• 

  Tiago Martins• 40

  @Tiago-Marts

  Submitted over 1 year ago

  I made some alterations from the original design, including:

  • Scrollbar when the text overflow: sometimes the advice text overflows the space so I add it.
  • Animation for the dice and loading: I think that adding animation in some elements would give more "life" to it. By the end, I was not 100% satisfied with the animations but I thinkt that works in general.
  • Constructing the icons: I know that is not recommended to do, but I find a fun activity trying to get the icons and details in pure CSS.

  It was a very fun challenge!

  Feedbacks are welcome!!

  

  Advice Generator App builded with Flexbox, JSON, JS and CSS

  2

  5

  1

  

  Shashank Gupta• 195

  @Shashank1003

  Posted over 1 year ago

  Hi Tiago! this solution looks good, you are handling long text nicely. But if you look at the small text on the small screen, it seems like the text is flying on the top with a lot of empty space at the bottom. To fix this, you can vertically align the advice text at the center (use flexbox) and give some margin-bottom to slightly uplift it.

  0
• 

  SAM• 820

  @SAM-dev-pixel

  Submitted over 2 years ago

  Hey, give me some suggestions about my codes. Html CSS javascript

  

  CSS and vanilla javascript

  2

  1

  0

  

  Shashank Gupta• 195

  @Shashank1003

  Posted over 2 years ago

  Hi, you can add CSS {cursor: pointer} for the items that have some actions on click. It will improve user experience as rn I don't know which elements can be clicked, it just shows the default mouse pointer.

  0
• 

  Bashir Dauda• 30

  @bashiribndawud

  Submitted over 2 years ago

  Feed back will be appreciated

  

  Testimonial grid section

  2

  1

  0

  

  Shashank Gupta• 195

  @Shashank1003

  Posted over 2 years ago

  Hey, hover animations aren't very smooth. Try to give at least 100-200 ms animation duration it will look better.

  0