@Tamar86
Tamara K.C
@Tamar86All comments
- @Tamar86
Applied the BEM naming convention throughout the code. This improves the clarity, organization, and maintainability of CSS. Using rem units instead of pixels which is a good practice as it provides better scalability and accessibility. Added focus styles.
- @Is-Ra-ElWhat are you most proud of, and what would you do differently next time?
I added social icons to the page.
What challenges did you encounter, and how did you overcome them?finding an icon for Frontend Mentor. fortunately, the favicon was included in the project files and i was able to use it.
What specific areas of your project would you like help with?how to create or use already created Favicons
@Tamar86My code uses some semantic HTML elements which is good for accessibility and SEO. I use a contrast ratio (light text on a dark background). Interactive elements, such as <li> items with hover effects, are implemented. Images use the alt attribute, which is essential for screen readers. The use of Flexbox (display: flex;) and Grid (display: grid;) properties provides a good foundation for responsive design. The code is generally well-organized, with clear class names that describe their purpose.
Marked as helpful - @GiorgiOsha95@Tamar86
Solution includes semantic HTML such as main, section, paragraph, etc. Layout looks good on desktop screen and also mobile. Code is well structured and CSS stylesheet is separated from HTML file. Solution does not differ much from the design.
- @Forester04@Tamar86
HTML structure is straightforward. For grouping related content, I could use <section> that could help with readability and organization. Layout uses flexbox and media queries, which is good for responsiveness. External CSS: Could move CSS to an external stylesheet for better separation of concerns and make the HTML file cleaner. This approach improves maintainability and reusability. Solution doesn't differ considerably from the design.
