@remyboire
Latest comments
- @ViyanMd
No problem! Could you share some info where you’ve learned how to implement the “download” module ?
- @remyboire@ViyanMd
Hey bud. Found an interesting bug for ya :) If you open a new file and refresh the page, the website goes down. Don't have much time to check what's the issue, so maybe you'd want to check on that yourself. Anyways, you've done an amazing work ( i'm impressed it's your first react app) !
- @Christ-Kevin@ViyanMd
Hi there! I am not an expert, but here's what worked well for me:
- Watch some Kevin Powell Youtube videos on responsiveness, layout and css units and media queries.
- Start with something simple. I am talking about literally practicing with one div or img, then combine an img and a div, the add some text. On each step make sure elements behave exactly how you want.
- As soon as you feel comfortable with something really simple, you can go ahead and start newbie challenges here.
- In programming curiosity is the key. You can ask Slack community for css resources and just go article after article. In most cases authors use simple examples to demonstrate what they are doing. After reading an article, try to repeat it by yourself without looking at the author's code.
Marked as helpful - @Nang-Su-Bway-Ni@ViyanMd
Well done! A couple things to fix to make it perfect :)
- Increase the padding for your "right" element.
- Fonts are a little off, so going with a different font size or weight would be great.
- The animation you've added looks great! (I've done something very similar). If you can, make it faster, because if feels like it's lagging.
- The mobile version is a little different from the desktop one, try to match the original design.
If you have any questions, feel free to ask!
- @BramMortier@ViyanMd
Hey! I'm glad you are making progress! A couple things about this project. The desktop version is stretched out both on x and y. Adding max-width and max-height or playing with flex-basis (if you are into flexbox) should solve the problem. Mobile version looks more or less better, but you should check your padding for the outer element as well. Also, the color of the input is a little different from what is in the control design, but that's an easy fix. Now, in regards JS. I assume you've decided to go with default 1 person, it solves the issue but if I put 0 in it, it doesn't give me the error message. I know no one will ever put 0 in there, but that's what the challenge is and you should challenge yourself to make it happen. Also, the tip amount gives "Nan" in some cases, so you should check values you are passing throughout the app. That's all I've found yet (don't have much time to go through you code at the moment), wish you good luck and happy coding. Feel free to ask questions.
Marked as helpful - @Richard2957@ViyanMd
Hey bud! Nice work! It took me about two hours to finish it, but I had to come back to it and add some animations + fix a couple things. One thing I've noticed is that you should fix the color of the text. The rest of it looks great. Also, 7 "ACCESSIBILITY ISSUES" is a little too much, but is easy to fix. Good luck!
