Jakub Zajac• 85
@jakubzajac
Submitted
It was the first time I've used BEM and CSS grid so any feedback regarding those is much appreciated.
Norbert Wronski
@WronskiN
All comments
- Norbert Wronski• 160
@WronskiN
Posted
In overall your solution looks good for me :).
However, what I would change:
I would add classes for some of html tags like h3 or span and style them with using classes.
In terms of the Grid style. On some screens the columns sets not same as on the project view. I would add for class .card-container { grid-template-columns: repeat(4, 1fr)} for bigger screens > 1024px;
Good job!
2 - Mladen• 410
@mladendjokovic
Submitted
Pls give your review of my site :)
Norbert Wronski• 160@WronskiN
Posted
Well done! I really like your solution, especially how you manage to do the dark/light mode switch. The only thing I am consider is that <h4> just after <h1> tag in html. I think it will be good to use <h2> and so. Anyway I like this project. It will be my next :).
1
