All comments

• 

  Andrew•20

  @am4188

  Submitted almost 3 years ago

  

  Product Preview Card using HTML and CSS

  2

  20
  

  Kate•170

  @YayoKB

  Posted almost 3 years ago

  I've only glanced at this for a bit so forgive me if this isn't incredibly constructive or helpful. :)

  1. You're using fixed widths (pixels instead of rem / em or vh, vw etc). This decreases the levels of accessibility and responsiveness, too.
  2. I haven't come across using spans the way you did. Is there any reason you did so?
  3. For some reason, .preview does not follow the same widths as its parent. That is why your button has strange sizing - it's simply following .preview which is bigger than your .container. I could be wrong though - I'm just starting out on here too.

  1

  Marked as helpful
• 

  Draco•160

  @dracowarz

  Submitted almost 3 years ago

  

  Product Preview Card Component Main

  2

  21
  

  Kate•170

  @YayoKB

  Posted almost 3 years ago

  • The site is not responsive. There are two layouts, one for desktop/wider screens and one for phones/taller screens. Your site does not change the layout depending upon the screen width. Please do that.
  • Some of your colours do not match exactly. The price and button should be a different green and the description and "PERFUME" label at the top should be in grey.

  1

  Marked as helpful